Opened 9 years ago

Closed 9 years ago

#7350 closed enhancement (fixed)

cleaning and fixing in ProcessController localization

Reported by: Karvjorm Owned by: siarzhuk
Priority: normal Milestone: R1
Component: Applications/ProcessController Version: R1/alpha2
Keywords: ProcessController CatalogEntryAttribute localization Cc: Karvjorm
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

There is still something to fix in ProcessController BAlert windows, in localization context definitions and in style issues. I tried to clean up and fix some errors.

Attachments (1)

processcontroller-fix.patch (13.8 KB ) - added by Karvjorm 9 years ago.
A clean up and fix for the ProcessController application

Download all attachments as: .zip

Change History (7)

by Karvjorm, 9 years ago

Attachment: processcontroller-fix.patch added

A clean up and fix for the ProcessController application

comment:1 by Karvjorm, 9 years ago

Has a Patch: set

in reply to:  1 ; comment:2 by siarzhuk, 9 years ago

1) What is the reason to change translation context in already translated application? Do you think that people have time to do the same translations again, again and again just from aesthetic reasons???
2) We do not localize the names of preference files!
3) We do not localize the names of preference files!
4) We do not localize the names of preference files!
5) We do not localize the names of preference files!
6) We do not localize the names of preference files!
7) For what you have localized the Deskbar item name again?
8) For what you have localized window class name again?
9) Why you do not reading revisions history before making your fixes??? Most of mentioned "fixes" were already removed as "excessive localization" in the past.

in reply to:  2 ; comment:3 by Karvjorm, 9 years ago

Replying to siarzhuk:

1) What is the reason to change translation context in already translated application? Do you think that people have time to do the same translations again, again and again just from aesthetic reasons???
2) We do not localize the names of preference files!
3) We do not localize the names of preference files!
4) We do not localize the names of preference files!
5) We do not localize the names of preference files!
6) We do not localize the names of preference files!

Translators need sometimes to check the context of text from the source code. Otherwise it is not possible to translate texts correctly. With other translations system (with .po files) it is easy, for example:

#: lib/error.c:259
#, c-format
msgid "%s: Cannot seek to %s"
msgstr ""

There you can see that text to translate can be found in error.c file on line 259. But when translating Haiku source code it is not possible. I have supposed, that

#undef B_TRANSLATE_CONTEXT #define B_TRANSLATE_CONTEXT "PCWorld"

type definitions can be used to find the file where the text can be found (PCWorld.cpp). But in this localization all files include definion

#define B_TRANSLATE_CONTEXT "ProcessController"

I think that it sucks. All of those texts to translate are not in ProcessController.cpp file. This localization is some Google Code-In project, I suppose. And this should have fixed before svn commit. I tried to do it now, but you disliked it.

Br, Karvjorm

7) For what you have localized the Deskbar item name again?
8) For what you have localized window class name again?
9) Why you do not reading revisions history before making your fixes??? Most of mentioned "fixes" were already removed as "excessive localization" in the past.

in reply to:  3 comment:4 by siarzhuk, 9 years ago

Replying to Karvjorm:

Replying to siarzhuk:

1) What is the reason to change translation context in already translated application? Do you think that people have time to do the same translations again, again and again just from aesthetic reasons???

Translators need sometimes to check the context of text from the source code. Otherwise it is not possible to translate texts correctly. I have supposed, that

#undef B_TRANSLATE_CONTEXT #define B_TRANSLATE_CONTEXT "PCWorld"

type definitions can be used to find the file where the text can be found (PCWorld.cpp). But in this localization all files include definion

#define B_TRANSLATE_CONTEXT "ProcessController"

I think that it sucks. All of those texts to translate are not in ProcessController.cpp file. This localization is some Google Code-In project, I suppose. And this should have fixed before svn commit. I tried to do it now, but you disliked it.

I'm sorry for the tone of the first comment, but please understand that changing context will invalidate all 11 translations of this app. And those 11 translators, including you, will be forced to do the same work again. And that is really bad idea to steal people's time without serious reasons.

From my point of view the same context for such compact applications is OK - at least it prevents from multiplying identical strings in the catkeys file. IMO, the knowledge of the CPP file in which the line was translated has less meaning for average translator. This person must be experienced person to understand the program source code and correlate it with the program interface objects. Usually it is simpler to play with translated program to adjust the translation with real context of using. BTW, this context never helped me in my translation work so I tend to count it as unnecessary dust. ;-)

comment:5 by siarzhuk, 9 years ago

Owner: changed from nobody to siarzhuk
Status: newassigned

comment:6 by siarzhuk, 9 years ago

Resolution: fixed
Status: assignedclosed

Applied in hrev40909. Thanks.

PS: Please compare that changeset with your original patch and avoid to renew rejected things.

Note: See TracTickets for help on using tickets.