BSynth destructor never called by BMidiSynth

[Pete]

MidiPlayer and other apps that use BMidiSynth were crashing on exit. Usually the MediaEventLooper was trying to handle an event after the data had gone away. In addition Cortex and the Audio Mixer panel would never delete their representations of Synth nodes. A bit of tracing showed that the BSynth destructor was never called.

Fixed in the attached patch. delete is invoked on be_synth when all clients have gone.

[korli]

OK, please fix the coding style.

[Pete]

style fix of original patch

[Pete]

Replying to korli:

OK, please fix the coding style.

Sigh... one line, and I can get it wrong! (:-/)

Corrected now.

BTW, I noticed that you looked at my USB_MIDI stuff (#4463) months ago, and reassigned it to phoudoin, but Philippe has never looked at it. Any chance of getting it committed? (It's essential for me, as the 2x2 is my standard interface to Haiku.)

[korli]

Applied in hrev41717. "be_synth = NULL" was added for good measure.

[Pete]

Replying to korli:

Applied in hrev41717. "be_synth = NULL" was added for good measure.

Thanks. (The nulling is probably a wise move!)

[Pete]

Replying to Pete:

Replying to korli:

Applied in hrev41717. "be_synth = NULL" was added for good measure.

Thanks. (The nulling is probably a wise move!)

Oops!! NO! Nulling be_synth causes a prompt, certain crash. Apparently it is accessed later somewhere.

The reason for my original patch was that the BSynth destructor stops the BMediaEventLooper before returning. (It does not crash with just that addition.)

[korli]

OK It might the reason why it was not deleted before hrev41717. Would you prefer we revert this patch?

[Pete]

Replying to korli:

Would you prefer we revert this patch?

Not the whole patch -- just remove the 'be_synth = NULL;' statement.

Leaving it out doesn't actually cause any problems. The absence of the 'delete', though, does cause the crashes and other problems mentioned originally, so it has to be there.

I'll look at what is actually referencing be_synth later, but I think it's better to have things solid even if not perfectly understood!

[Pete]

Dohh -- my bad. I applied the added line wrongly!!

There is nothing wrong with the patch as committed. Please close this ticket again as fixed.

Many apologies (:-()

[korli]

Thanks for the feedback Pete!