Vertically resizing leaves redrawing artifacts

[humdinger]

This is R1/alpha hrev41843.

• Open the Sounds prefs
• Resize slowly vertically

-> vertical lines:

[humdinger]

artifacts when resizing Sounds prefs

[idefix]

Might be the same as ticket:3037.

[diver]

I think that it's a redraw issue in ColumnListView.

[x-ist]

It seems there is an off-by-one error in the passed-in invalidBounds parameter of OutlineView::Draw(BRect invalidBounds) in ColumnListView.cpp. I still have to investigate where exactly the miscalculation happens though.

If the method is changed like this:

void
OutlineView::Draw(BRect invalidBounds)
{
	invalidBounds.top -= 1;
	invalidBounds.left -= 1;

#if SMART_REDRAW
	BRegion invalidRegion;
	GetClippingRegion(&invalidRegion);
#endif

	...

the glitches disappear, and not only the horizontal ones at the bottom!

In line 3398 the focus row can then be drawn with the correct width

	StrokeRect(BRect(0, line, invalidBounds.right, line + rowHeight));

instead of

	StrokeRect(BRect(0, line, 10000.0, line + rowHeight));

which I suppose was done due to glitches upon resizing the window to the right.

[siarzhuk]

Replying to Janus:

That looks reasonable. After applying your patch I cannot reproduce this vertical resize artifacts anymore. Thank you.

[siarzhuk]

Ups, that was hrev45010. Excuse me, please...