Opened 8 years ago

Closed 7 years ago

#7683 closed enhancement (fixed)

BWindow needs a LayoutChanged() hook method

Reported by: yourpalal Owned by: yourpalal
Priority: normal Milestone: R1/beta1
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #5524
Has a Patch: no Platform: All

Description

See for reference the discussion on haiku-commits about hrev42106

Change History (5)

comment:1 Changed 8 years ago by yourpalal

Here's a link to the relevant thread on the ml: http://www.freelists.org/post/haiku-commits/r42106-haikutrunksrcpreferencestime

Looking at the source for BView, I think a good place to call this hook would be once the view, and all of its children have finished doing layout. This way, we are actually providing functionality beyond what you can get by overriding DoLayout(). I don't think this hook fits in BWindow, since it delegates drawing/layout to views and layouts; it doesn't do any of this work itself.

We currently have 5 remaining BView virtual methods, so I see no problem with adding this method. If anyone disagrees, reply here, if nobody replies to the contrary soon, I'll implement this (should take about 2 seconds).

comment:2 Changed 8 years ago by yourpalal

Status: newin-progress

Fixed in my github repo

I'll push this to git.haiku-os.org once the svn -> git migration is complete. In the mean time, anyone who wants is free to review my fix at the link above.

comment:3 Changed 8 years ago by scottmc

we're on git now...

comment:4 in reply to:  3 Changed 8 years ago by yourpalal

Replying to scottmc:

we're on git now...

Haha yeah. Maybe I should have said _after_ the migration is complete ;) I need to do a full build on my little laptop to perform integration testing of this and other changes, which I've been putting off since it is pretty slow. This change could probably be pushed safely on its own, but it's in between a bunch of other layout changes.

comment:5 Changed 7 years ago by yourpalal

Resolution: fixed
Status: in-progressclosed

Fixed in hrev43514, specifically changeset 0c8b758c09

Note: See TracTickets for help on using tickets.