Deskbar crashs when Battery::GetBatteryInfoCached

[Arnaud M.]

Hi,

I have recently installed Haiku alpha 3 as the single operating system of an old laptop Nec Versa (see attachment for details) and I would like to report a crash of the deskbar without explicit reason i.e. I was just surfing on the net using WebPositive.

The bug is quitely reproductible and seems to happen each time I use WebPositive. And when I launch gdb, it appears that we have stopped during the GetBatteryInfo of PowerStatusView.

I attached all files I thought necessary in this ticket (the description is the README files so read the readme first)

Hope this helps.

[Arnaud M.]

Let the "WebPositive" clue over, the crash has just hapened now without WebPositive running ... I attach 2 new files (syslog_deskbar_crash2.log and gdb_BatteryStatus2) related to this occurence in order to eventually put in evidence a common point.

[Arnaud M.]

syslog just after a crash of the deskbar

[modeenf]

Can you attatch a screnshot of you detail view of your battery from PowerStatus?

[Arnaud M.]

Replying to modeenf:

Can you attatch a screnshot of you detail view of your battery from PowerStatus?

I don't know if my attachment (detailed_battery_status.png) is what you want so do not hesitate to precise your request if I am wrong.

[modeenf]

Yes it's the one :)

looks like there are some errors in your reported battery.

Does it still happends?

[Wizard]

crash report

[Wizard]

As of hrev46415 this still happens on my asus t101mt. Deskbar crashes randomly when PowerStatus replicant is installled in it.

[korli]

​fRateBuffer.GetMeanRate() can be zero and provokes a divide error.

[modeenf]

Would changing line 101

if (fCachedAcpiInfo.current_rate > 0)

to

if (fCachedAcpiInfo.current_rate > 0 || fRateBuffer.GetMeanRate() > 0)

fix that?

or chould one add

int meanRate = fRateBuffer.GetMeanRate(); 
if (fCachedAcpiInfo.current_rate > 0 ||  meanRate > 0) 
		info->time_left = 3600 * fCachedAcpiInfo.capacity
			/ meanRate;

[tqh]

IMO GetMeanRate return value should be checked and the logic have different cases for 0, -1 and >0. -1: a error code (-1?), currently it is used in calculation. 0: should return infinity. greater than 0: calculate.

Perhaps this shouldn't be integer math at all.

[korli]

Replying to modeenf:

Would changing line 101 if (fCachedAcpiInfo.current_rate > 0) to if (fCachedAcpiInfo.current_rate > 0 || fRateBuffer.GetMeanRate() > 0) fix that?

if (fCachedAcpiInfo.current_rate > 0 && fRateBuffer.GetMeanRate() > 0) would be fine.

Sorry BTW I clicked on "Edit" instead of "Answer", and accidentally modified your comment.

[korli]

Applied a fix in hrev46454.

[korli]

Assume fixed.