#7917 closed enhancement (invalid)
Make the exported RDEF header more useful
| Reported by: | mmadia | Owned by: | stippi |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Applications/Icon-O-Matic | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
This patch changes the rdef header to one that can be used by Haiku's build system. AFAICT, the current header is broken -- due the opening curly brace occuring within the comment -- resource(<your resource id here>) #'VICN' array {
Attachments (1)
Change History (7)
by , 13 years ago
| Attachment: | icon-o-matic_rdef-header.patch added |
|---|
comment:1 by , 12 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 9 years ago
comment:3 by , 9 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Invalid, according to Stephan on IRC.
comment:4 by , 9 years ago
And here is why it is invalid:
- #'VICN' is the same as vector_icon. We could use the latter for better readability, maybe
- The # is not starting a comment, but the tag for a raw 4 character type
- You do need to set a resource ID, and the patch wrongly remove that part
comment:5 by , 9 years ago
A bit differently. The export from I-O-M is supposed to let you define your own resource ID (and help you with the rdef syntax). "vector_icon" is a shortcut that was added later to rc (?) and it not only sets the array type (#'VICN'), but also the resource ID to one that is reserved for file icons (IIRC). And that is what I don't like about the patch.
Also, I don't understand why there is any problem in the first place. I use this declaration for example in the HaikuDepot rdef file, and there are no problems, are there?
http://cgit.haiku-os.org/haiku/tree/src/apps/haikudepot/HaikuDepot.rdef
comment:6 by , 9 years ago
... maybe someone forgot to actually change the "<your resource id here>" part for an actual ID and thought the syntax is broken?
LGTM. Anyone see a reason not to apply this?