Opened 8 years ago

Last modified 8 years ago

#7997 new bug

Selecting a large range of text within terminal, then right-clicking on selected text locks up the terminal application.

Reported by: frankenburps Owned by: jackburton
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/alpha3
Keywords: gci2011 Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This happens to me consistently. Am running the release version of r1a3, running in VMware fusion 4.1.2 for macos x 10.6.8.

Attachments (1)

crashedterminal.png (241.4 KB) - added by frankenburps 8 years ago.
after selecting text in terminal and right-clicking within selected text to try to call up a menu to copy the text

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by frankenburps

Attachment: crashedterminal.png added

after selecting text in terminal and right-clicking within selected text to try to call up a menu to copy the text

comment:1 Changed 8 years ago by frankenburps

When I shut down haiku after this happens, I'm told the terminal "might be blocked on a modal panel". Have to kill it to shut down.

comment:2 Changed 8 years ago by frankenburps

To reproduce this, for example, install tiltos. IN terminal, type box-repos -s to get a list of all packages. Select the full list of package names. Right-click in the hopes of getting a menu with the copy option. The terminal will crash.

comment:3 Changed 8 years ago by stippi

Component: User InterfaceApplications/Terminal
Owner: changed from stippi to jackburton

Thanks for the report! When an application crashes, you should receive an error prompt with an option to debug the crashed application. If you don't receive the prompt, it would appear that Terminal locks up, either in a busy loop or in a dead-lock, rather than crashes.

comment:4 Changed 8 years ago by frankenburps

Summary: Selecting a large range of text within terminal, then right-clicking to try to call up a menu crashes the terminal application.Selecting a large range of text within terminal, then right-clicking on selected text locks up the terminal application.

comment:5 Changed 8 years ago by pepol

Keywords: gci2011 added

The problem was checked during GCI 2011. It happens to me, on hrev43238, running on VirtualBox 4.1.4 (Debian Sid) and does exactly, as it says in description: If you select a large portion of text and then want to copy it, it freezes.

comment:6 Changed 8 years ago by siarzhuk

JFYI: That looks like the concurrency problem in our pty implementation:
a) Selecting the the text in terminal automatically copy the selection into the clipboard;
b) Pressing either middle or right button inserts current text from the clipboard into the Terminal;
c) Terminal writes all those strings at once - and it looks like the app is blocked because of some reasons the text doesn't displayed on the screen;
d) Anyway at some time the TermParse::PtyReader become "Bad file descriptor" error on the next attempt to read and is forced to exit with NotifyQuit() call.

From the other side: What sense to paste those thousands of lines into the Terminal? Note that they are interpreted as usual CLI commands and shell attempts to run them immediately and produce error messages. May be pasting should be blocked for any multilined contents?

comment:7 in reply to:  6 ; Changed 8 years ago by anevilyak

Replying to siarzhuk:

From the other side: What sense to paste those thousands of lines into the Terminal? Note that they are interpreted as usual CLI commands and shell attempts to run them immediately and produce error messages. May be pasting should be blocked for any multilined contents?

That's a perfectly valid use case if your terminal currently contains, e.g. an open session of vim.

comment:8 in reply to:  7 Changed 8 years ago by siarzhuk

Replying to anevilyak:

Replying to siarzhuk:

From the other side: What sense to paste those thousands of lines into the Terminal? Note that they are interpreted as usual CLI commands and shell attempts to run them immediately and produce error messages. May be pasting should be blocked for any multilined contents?

That's a perfectly valid use case if your terminal currently contains, e.g. an open session of vim.

Yes, just have checked it under my "reference" FreeBSD xterm. ;-)

Note: See TracTickets for help on using tickets.