Opened 12 years ago

Closed 9 years ago

#8171 closed enhancement (fixed)

[Media] move media services restart alert to BNotification (easy)

Reported by: diver Owned by: anevilyak
Priority: normal Milestone: R1
Component: Preferences/Media Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description (last modified by pulkomandy)

Clicking the "restart media services" button opens a status window that looks like an alert with no buttons. Since this is non-blocking, it should use the BNotification API instead to show a standard notification.

Change History (16)

comment:1 by pulkomandy, 9 years ago

Description: modified (diff)
Summary: [Media] move media services restart alert to BNotification[Media] move media services restart alert to BNotification (easy)

comment:2 by MrPingouin, 9 years ago

I start working on this one.

comment:3 by MrPingouin, 9 years ago

patch: 01

comment:4 by MrPingouin, 9 years ago

This patch updates preferences/media application, and libmedia.so at the same time.

comment:5 by pulkomandy, 9 years ago

patch: 10

comment:6 by pulkomandy, 9 years ago

The shutdown_media_server is part of the public BeOS API: file:///boot/system/documentation/BeBook/TheMediaKit_Functions.html

So you are not allowed to change it to remove the "message" parameter to the callback, this would break compatibility with BeOS. Other parts of the changes look fine.

comment:7 by MrPingouin, 9 years ago

patch: 01

comment:8 by MrPingouin, 9 years ago

Done. Patch is fixing Media preferences only.

comment:9 by pulkomandy, 9 years ago

There are some style issues now:

  • no newline between if and opening brace:
    if (condition) {
    ...
    }
    
  • I think some lines of code are now longer than 80 chars.

comment:10 by MrPingouin, 9 years ago

As requested by Pulkomandy, this version uses only local variables instead of pointers variables.

comment:11 by MrPingouin, 9 years ago

Patch was not working. I did a pull --rebase and a reset --hard HEAD~1 to generate this one.

Everything should be ok except that I mispelled the file :)

comment:12 by pulkomandy, 9 years ago

Applied the patch and more fixes in hrev48501.

comment:13 by pulkomandy, 9 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.