Opened 13 years ago
Closed 10 years ago
#8171 closed enhancement (fixed)
[Media] move media services restart alert to BNotification (easy)
Reported by: | diver | Owned by: | anevilyak |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Preferences/Media | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description (last modified by )
Clicking the "restart media services" button opens a status window that looks like an alert with no buttons. Since this is non-blocking, it should use the BNotification API instead to show a standard notification.
Attachments (3)
Change History (16)
comment:1 by , 10 years ago
Description: | modified (diff) |
---|---|
Summary: | [Media] move media services restart alert to BNotification → [Media] move media services restart alert to BNotification (easy) |
comment:2 by , 10 years ago
by , 10 years ago
Attachment: | 0001-Media-Service-restart-is-now-using-BNotification.patch added |
---|
comment:3 by , 10 years ago
patch: | 0 → 1 |
---|
comment:4 by , 10 years ago
This patch updates preferences/media application, and libmedia.so at the same time.
comment:5 by , 10 years ago
patch: | 1 → 0 |
---|
comment:6 by , 10 years ago
The shutdown_media_server is part of the public BeOS API: file:///boot/system/documentation/BeBook/TheMediaKit_Functions.html
So you are not allowed to change it to remove the "message" parameter to the callback, this would break compatibility with BeOS. Other parts of the changes look fine.
comment:7 by , 10 years ago
patch: | 0 → 1 |
---|
comment:9 by , 10 years ago
There are some style issues now:
- no newline between if and opening brace:
if (condition) { ... }
- I think some lines of code are now longer than 80 chars.
by , 10 years ago
Attachment: | 0001-Media-service-restart-is-now-using-BNotification-Ticket-8171.patch added |
---|
comment:10 by , 10 years ago
As requested by Pulkomandy, this version uses only local variables instead of pointers variables.
by , 10 years ago
Attachment: | 0001-Media-service-restart-is-now-using-BNotification.Ticket-8171.patch added |
---|
comment:11 by , 10 years ago
Patch was not working. I did a pull --rebase and a reset --hard HEAD~1 to generate this one.
Everything should be ok except that I mispelled the file :)
comment:13 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I start working on this one.