Weird characters in gdb Terminal title

[humdinger]

This is hrev43375.

When entering gdb after a crash or debugging a thread, the Terminal title sports some curious characters:

[humdinger]

Weird characters

[humdinger]

After a suggestion by DeadYak, I tried hrev43318. No problems there.

[anevilyak]

Had a quick look, and I'm somewhat puzzled right now... the diff for debug_server itself as part of ​hrev43319 at least looks fine, and Terminal had no changes.

[anevilyak]

On second thought, I might see the problem. The paths that get assigned inside _SetupGDBArguments() are assigned from BPath objects that are set up on the stack, and not copied. These potentially get trashed afterwards when returning from there and executing other things, leaving us with a bogus argv array, no?

[bonefish]

Replying to anevilyak:

On second thought, I might see the problem. The paths that get assigned inside _SetupGDBArguments() are assigned from BPath objects that are set up on the stack, and not copied. These potentially get trashed afterwards when returning from there and executing other things, leaving us with a bogus argv array, no?

Yes, the window title is also on the stack. Furthermore _SetupGDBArguments() should really return a status_t.

[anevilyak]

Will try to find time to deal with it this weekend then. Thanks!

[humdinger]

I now tried hrev43319 and that shows the same issue... sorry guys...

[SeanCollins]

Problem with charecters inside the terminal window itself as well. screenshot attached.hrev 43354-dirty gcc2hybrid

[siarzhuk]

Replying to SeanCollins:

Problem with charecters inside the terminal window itself as well. screenshot attached.hrev 43354-dirty gcc2hybrid

That one has nothing to do with the Terminal - the bash profile was not loaded because of settings path change some weeks ago - it should be fixed in the recent revisions. Just check and open another bug if it still observed. Please remove the attachment from this ticket.

Replying to humdinger:

I now tried hrev43319 and that shows the same issue... sorry guys...

Handling of OSC ANSI codes are done here ​http://cgit.haiku-os.org/haiku/tree/src/apps/terminal/TermParse.cpp#n1043 can you check with putting some dprintf tracing about the header gdb which trying to set in Terminal? May be some garbage data was interpreted as ANSI OSC sequence.

Are there any way to reproduce this situation?

[SeanCollins]

Replying to siarzhuk:

Replying to SeanCollins:

Problem with charecters inside the terminal window itself as well. screenshot attached.hrev 43354-dirty gcc2hybrid

That one has nothing to do with the Terminal - the bash profile was not loaded because of settings path change some weeks ago - it should be fixed in the recent revisions. Just check and open another bug if it still observed. Please remove the attachment from this ticket.

I can't edit the ticket. and the hrev I am on is 5 days old.

[anevilyak]

Proposed fix

[anevilyak]

Attached a patch for review: We now pass in a BString object that _SetupGDBArguments() can build up its command string in, with marker characters indicating the bounds of the arguments, then replace those with nulls before building up the argv array. This ensures that the character buffer for all the args is valid when calling load_image(). Thoughts?

[bonefish]

Mmh, not so nice IMO. I'd use the BStringList class (which I sneaked in recently) to construct the arguments list and prepare the argv vector from it just before calling load_image().

BTW, the patch also contains debug output in src/kits/interface/ColumnListView.cpp.

[anevilyak]

Replying to bonefish:

Mmh, not so nice IMO. I'd use the BStringList class (which I sneaked in recently) to construct the arguments list and prepare the argv vector from it just before calling load_image().

Wish I'd known about that one sooner :) will rework it, thanks for the hint.

[anevilyak]

Fixed in hrev43431.