Opened 7 years ago

Closed 3 years ago

#8194 closed enhancement (fixed)

Rid Workspaces app of decorator related constants

Reported by: devine Owned by: leavengood
Priority: normal Milestone: R1
Component: Applications/Workspaces Version: R1/alpha3
Keywords: hardcoded, decoration, width Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Relating to the change I am making in #8188 I have gotten rid of hardcoded decorator widths and replaced with code to get decoration widths dynamically.

Can I please get some comments on the attached code as I've never done anything like this.

Attachments (1)

Workspaces-Constants-Removed.diff (8.2 KB) - added by devine 7 years ago.
Initial work to get rid of hardcoded decorator constants.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by devine

Has a Patch: set

comment:2 Changed 7 years ago by devine

Updated with a version that actually works properly. The previous version didn't handle not having a pre-existing settings file.

comment:3 Changed 7 years ago by devine

A new version... Sorry! Fixed a problem with the way window settings were set (and then were saved) causing the window to come up off-screen after the second time using the application.

Changed 7 years ago by devine

Initial work to get rid of hardcoded decorator constants.

comment:4 Changed 7 years ago by mmadia

#8188 seems to have a newer patch by devine, which should fix the issue.

comment:5 Changed 7 years ago by leavengood

Owner: changed from axeld to leavengood
Status: newin-progress

Take ownership as I'm working with the patch from #8188.

comment:6 Changed 3 years ago by pulkomandy

Has a Patch: unset

comment:7 Changed 3 years ago by pulkomandy

Resolution: fixed
Status: in-progressclosed

Applied manually in hrev50549.

Note: See TracTickets for help on using tickets.