Opened 12 years ago
Closed 8 years ago
#8194 closed enhancement (fixed)
Rid Workspaces app of decorator related constants
| Reported by: | devine | Owned by: | leavengood |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Applications/Workspaces | Version: | R1/alpha3 |
| Keywords: | hardcoded, decoration, width | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Relating to the change I am making in #8188 I have gotten rid of hardcoded decorator widths and replaced with code to get decoration widths dynamically.
Can I please get some comments on the attached code as I've never done anything like this.
Attachments (1)
Change History (8)
comment:1 by , 12 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 12 years ago
comment:3 by , 12 years ago
A new version... Sorry! Fixed a problem with the way window settings were set (and then were saved) causing the window to come up off-screen after the second time using the application.
by , 12 years ago
| Attachment: | Workspaces-Constants-Removed.diff added |
|---|
Initial work to get rid of hardcoded decorator constants.
comment:4 by , 12 years ago
#8188 seems to have a newer patch by devine, which should fix the issue.
comment:5 by , 12 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → in-progress |
Take ownership as I'm working with the patch from #8188.
comment:6 by , 8 years ago
| patch: | 1 → 0 |
|---|
comment:7 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | in-progress → closed |
Applied manually in hrev50549.
Note:
See TracTickets
for help on using tickets.
Updated with a version that actually works properly. The previous version didn't handle not having a pre-existing settings file.