Opened 8 years ago

Closed 7 years ago

#8253 closed enhancement (fixed)

Pull request for Workspaces

Reported by: devine Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Workspaces Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Git URL: https://bitbucket.org/ddevine/haiku.git

The Workspaces branch has a number of features:

  • Fixed auto-raise (see #8188)
  • Removed hardcoded decorator constants
  • Style cleanups

Change History (7)

comment:1 by jscipione, 8 years ago

First of all the above link doesn't work, second of all we prefer patches instead of pull requests. Please attach a patch to the ticket instead. You can create a patch by running:

git diff --no-prefix origin master > patchfile.diff

in the root haiku/ directory assuming that the official haiku repository is set to origin.

Last edited 8 years ago by jscipione (previous) (diff)

comment:2 by devine, 8 years ago

If you saw the haiku-dev mailing list discussion I thought that it was agreed that the way to do a pull request was within the bug tracker. Given that Haiku now has a DVCS some people were interested in going through the process of using it as such.

I should have used git:// on that url to make it obvious - it does work, but it is not for browsing.

If you want to browse, try this url: https://bitbucket.org/ddevine/haiku/changesets

comment:3 by jscipione, 8 years ago

I missed the haiku-dev mailing list discussion that you were experimenting with doing a pull request. My appologies. I'll check out the URL and check out your changes.

comment:4 by axeld, 8 years ago

The idea behind a pull request rather than a simple patch is that the former will include the history of the change, and can also separate different things like coding style cleanup, and a bug fix from each other easily.

in reply to:  4 comment:5 by korli, 8 years ago

Replying to axeld:

The idea behind a pull request rather than a simple patch is that the former will include the history of the change, and can also separate different things like coding style cleanup, and a bug fix from each other easily.

The command

git format-patch --keep-subject -o out origin

will generate a patch per commit in the out directory, which can then be attached. It can eventually make it more obvious for the bug reviewer to have patchs attached to the bug report.

comment:6 by bonefish, 8 years ago

OTOH the advantage of a branch is that the contributor can keep it up to date (by rebasing) without needing to spam the ticket. Particularly when it's more than just a few commits attaching them to a ticket becomes increasingly inconvenient.

comment:7 by mmadia, 7 years ago

Resolution: fixed
Status: newclosed

Closing this, as it appears that devine attached the code in question to #8188. Please re-open if this isn't the case.

And thanks for the patch!

Note: See TracTickets for help on using tickets.