Opened 8 years ago

Closed 19 months ago

#8373 closed bug (fixed)

Syslog should be skipped by Installer (easy)

Reported by: jonas.kirilla Owned by: korli
Priority: normal Milestone: R1
Component: Applications/Installer Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

The syslog is copied over by the Installer, from source to target.

I would expect a clean install to have an empty syslog.

Change History (7)

comment:1 by Disreali, 8 years ago

What is the source you are using?

IIRC, Installer copies everything from source to the target.

IOW, Once you boot an install, a syslog is created and Installer will be copy it, as well as everything else on the source install partition, to the target. That is the expected behavior.

in reply to:  1 comment:2 by jonas.kirilla, 8 years ago

Replying to Disreali:

What is the source you are using?

In this case, a CD.

Copying over the syslog of a CD boot or a USB boot over to e.g. HD, as part of the installation may very well be expected - as copying is what Installer does - but I think it should be skipped so that the first syslog entry of a clean install always is about the very first boot of that installation, rather than for it to be appended to the previous syslog from the boot of the install media.

Granted, most factors are shared, and the syslog content is roughly the same.

comment:3 by korli, 19 months ago

Summary: Syslog should be skipped by InstallerSyslog should be skipped by Installer (easy)

comment:4 by kimb18h, 19 months ago

The EntryFilter object in the WorkerThread class appears to have a set of paths that are ignored during the copy operation (see https://git.haiku-os.org/haiku/tree/src/apps/installer/WorkerThread.cpp#n87)

I believe that this bug can be resolved by simply adding the syslog file's path to the set of ignored paths. If that's correct, I'll work on the patch.

in reply to:  4 comment:5 by korli, 19 months ago

Replying to kimb18h:

I believe that this bug can be resolved by simply adding the syslog file's path to the set of ignored paths. If that's correct, I'll work on the patch.

Agreed. "system/var/log/syslog" should cover syslog and syslog.old.

comment:7 by waddlesplash, 19 months ago

Resolution: fixed
Status: newclosed

Merged in hrev51863.

Note: See TracTickets for help on using tickets.