Opened 13 years ago
Closed 12 years ago
#8378 closed bug (fixed)
GUI issue in Screenshot panel (easy)
Reported by: | humdinger | Owned by: | yourpalal |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Applications/Screenshot | Version: | R1/Development |
Keywords: | Cc: | mdisreali@…, adam.s.hartford@… | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
This is hrev43800.
The Screenshot panel shows some GUI drawing issues, see screenshot:
The background of the pop-up menu labels are white and the grey border around the preview seems to be set a few pixels down and right.
Attachments (3)
Change History (16)
by , 13 years ago
Attachment: | screenshot.png added |
---|
comment:1 by , 13 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 13 years ago
Summary: | GUI issue in Screenshot panel → GUI issue in Screenshot panel (easy) |
---|
Okay, my insight from looking at the screenshot is we've got two problems:
- BMenuField gets its background colour from its parent, but when it is added directly to a window, the parent view is inaccessible, so it must be done by the programmer.
- That border problem... not sure what that's about, maybe someone could do a bisect to find out when it appeared.
Anyway, I think this would make a good 'easy' ticket, so I'm setting it as such.
Edit: problem #1 occurs when the menu field is added directly to a window, not a view.
comment:3 by , 13 years ago
This issue has been around awhile. IIRC, it started after the layout changes in hrev43514.
Sorry, like others on irc, I thought there was already a ticket for this issue.
comment:4 by , 13 years ago
Cc: | added |
---|
comment:5 by , 13 years ago
If you don't have bandwidth for this one, @yourpalal, I'm more than willing to work on this. I'd like to be more regularly involved with the easy fixes. :)
comment:6 by , 13 years ago
Hi composr, that would be great. I actually put it as an 'easy' ticket in hopes someone who wanted to get going with Haiku could pick it up, so that works well. I'll be here to help so please ask if you have any questions.
comment:7 by , 13 years ago
patch: | 0 → 1 |
---|
comment:8 by , 13 years ago
Cc: | added |
---|
I've created a patch to fix these issues. To anyone applying the patch themselves: you'll want to copy the new Screenshot app to /boot/system/apps/ so that when the app relaunches itself to capture a screenshot, the patched version is launched.
comment:9 by , 13 years ago
Hi ahartford, thanks for you work :) Your patch looks good, once I have time I'll apply and commit it. (Assuming there are no problems)
comment:10 by , 13 years ago
Cc: | removed |
---|
comment:11 by , 13 years ago
Cc: | added |
---|
comment:13 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I finally got around to applying this patch and pushed it in hrev44297. Thanks for your work, ahartford.
GUI drawing issues