Opened 8 years ago

Closed 7 years ago

#8378 closed bug (fixed)

GUI issue in Screenshot panel (easy)

Reported by: humdinger Owned by: yourpalal
Priority: normal Milestone:
Component: Applications/Screenshot Version: R1/Development
Keywords: Cc: mdisreali@…, adam.s.hartford@…
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This is hrev43800.

The Screenshot panel shows some GUI drawing issues, see screenshot:

GUI drawing issues

The background of the pop-up menu labels are white and the grey border around the preview seems to be set a few pixels down and right.

Attachments (3)

screenshot.png (15.1 KB ) - added by humdinger 8 years ago.
GUI drawing issues
ticket_8378.patch (4.7 KB ) - added by ahartford 7 years ago.
Patch to fix GUI issues
ticket_8378_fixed.png (21.8 KB ) - added by ahartford 7 years ago.
Screenshot with GUI issues fixed

Download all attachments as: .zip

Change History (16)

by humdinger, 8 years ago

Attachment: screenshot.png added

GUI drawing issues

comment:1 by diver, 8 years ago

Owner: changed from nobody to yourpalal
Status: newassigned

comment:2 by yourpalal, 8 years ago

Summary: GUI issue in Screenshot panelGUI issue in Screenshot panel (easy)

Okay, my insight from looking at the screenshot is we've got two problems:

  1. BMenuField gets its background colour from its parent, but when it is added directly to a window, the parent view is inaccessible, so it must be done by the programmer.
  2. That border problem... not sure what that's about, maybe someone could do a bisect to find out when it appeared.

Anyway, I think this would make a good 'easy' ticket, so I'm setting it as such.

Edit: problem #1 occurs when the menu field is added directly to a window, not a view.

Last edited 7 years ago by yourpalal (previous) (diff)

comment:3 by Disreali, 8 years ago

This issue has been around awhile. IIRC, it started after the layout changes in hrev43514.

Sorry, like others on irc, I thought there was already a ticket for this issue.

comment:4 by Disreali, 8 years ago

Cc: mdisreali@… added

comment:5 by composr, 7 years ago

If you don't have bandwidth for this one, @yourpalal, I'm more than willing to work on this. I'd like to be more regularly involved with the easy fixes. :)

comment:6 by yourpalal, 7 years ago

Hi composr, that would be great. I actually put it as an 'easy' ticket in hopes someone who wanted to get going with Haiku could pick it up, so that works well. I'll be here to help so please ask if you have any questions.

by ahartford, 7 years ago

Attachment: ticket_8378.patch added

Patch to fix GUI issues

comment:7 by ahartford, 7 years ago

Has a Patch: set

comment:8 by ahartford, 7 years ago

Cc: ahartford added

I've created a patch to fix these issues. To anyone applying the patch themselves: you'll want to copy the new Screenshot app to /boot/system/apps/ so that when the app relaunches itself to capture a screenshot, the patched version is launched.

by ahartford, 7 years ago

Attachment: ticket_8378_fixed.png added

Screenshot with GUI issues fixed

comment:9 by yourpalal, 7 years ago

Hi ahartford, thanks for you work :) Your patch looks good, once I have time I'll apply and commit it. (Assuming there are no problems)

comment:10 by ahartford, 7 years ago

Cc: ahartford removed

comment:11 by ahartford, 7 years ago

Cc: adam.s.hartford@… added

comment:12 by Giova84, 7 years ago

hrev44240: Screenshot panel still shows GUI drawing issues.

comment:13 by yourpalal, 7 years ago

Resolution: fixed
Status: assignedclosed

I finally got around to applying this patch and pushed it in hrev44297. Thanks for your work, ahartford.

Note: See TracTickets for help on using tickets.