Opened 13 years ago
Last modified 8 years ago
#8422 assigned bug
UserlandFS server doesn't compile with DEBUG
Reported by: | pdziepak | Owned by: | pdziepak |
---|---|---|---|
Priority: | normal | Milestone: | Unscheduled |
Component: | File Systems/UserlandFS | Version: | R1/alpha3 |
Keywords: | gsoc2012 | Cc: | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
In debug mode GCC2 doesn't remove unused static inline
functions, this causes linking errors in userlandfs server.
The solution is borrowed from libuserlandfs_haiku_kernel.so
. Unused but required functions are present with empty implementations or linked using kernelland_emu.
Attachments (1)
Change History (7)
by , 13 years ago
Attachment: | userlandfs_debug.patch added |
---|
comment:1 by , 13 years ago
patch: | 0 → 1 |
---|
comment:2 by , 13 years ago
comment:3 by , 12 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 10 years ago
The patch doesn't work anymore, as the scheduler has changed a bit and it provides some of those inlined functions.
I think I don't understand the FS code well enough to do anything here to implement what Ingo suggests, unless given more details. So help fixing this would be very welcome.
comment:5 by , 9 years ago
Milestone: | R1 → Unscheduled |
---|
BeOS did not have UserlandFS, moving out of R1
comment:6 by , 8 years ago
patch: | 1 → 0 |
---|
I don't really like this solution. The server should avoid private kernel headers and it does save for
<Notifications.h>
to handle theNodeMonitoringEventRequest
. It should instead rather delegate the invocation of the listener hook to the respective kernel interface library.Regarding coding style: The
}
doesn't go on the same line as the{
, even if the function body is empty. Exceptions may be made for lists of reserved methods to avoid unnecessarily bloating the source file (e.g. http://cgit.haiku-os.org/haiku/tree/src/kits/interface/View.cpp#n5846), but then the whole function definition is on the same line.