Opened 7 years ago

Last modified 2 years ago

#8422 assigned bug

UserlandFS server doesn't compile with DEBUG

Reported by: pdziepak Owned by: pdziepak
Priority: normal Milestone: Unscheduled
Component: File Systems/UserlandFS Version: R1/alpha3
Keywords: gsoc2012 Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

In debug mode GCC2 doesn't remove unused static inline functions, this causes linking errors in userlandfs server.

The solution is borrowed from libuserlandfs_haiku_kernel.so. Unused but required functions are present with empty implementations or linked using kernelland_emu.

Attachments (1)

userlandfs_debug.patch (2.6 KB) - added by pdziepak 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by pdziepak

Attachment: userlandfs_debug.patch added

comment:1 Changed 7 years ago by pdziepak

Has a Patch: set

comment:2 Changed 7 years ago by bonefish

I don't really like this solution. The server should avoid private kernel headers and it does save for <Notifications.h> to handle the NodeMonitoringEventRequest. It should instead rather delegate the invocation of the listener hook to the respective kernel interface library.

Regarding coding style: The } doesn't go on the same line as the {, even if the function body is empty. Exceptions may be made for lists of reserved methods to avoid unnecessarily bloating the source file (e.g. http://cgit.haiku-os.org/haiku/tree/src/kits/interface/View.cpp#n5846), but then the whole function definition is on the same line.

comment:3 Changed 6 years ago by mmadia

Owner: changed from bonefish to pdziepak
Status: newassigned

comment:4 Changed 5 years ago by pulkomandy

The patch doesn't work anymore, as the scheduler has changed a bit and it provides some of those inlined functions.

I think I don't understand the FS code well enough to do anything here to implement what Ingo suggests, unless given more details. So help fixing this would be very welcome.

comment:5 Changed 4 years ago by waddlesplash

Milestone: R1Unscheduled

BeOS did not have UserlandFS, moving out of R1

comment:6 Changed 2 years ago by pulkomandy

Has a Patch: unset
Note: See TracTickets for help on using tickets.