Opened 10 years ago

Last modified 5 years ago

#8422 assigned bug

UserlandFS server doesn't compile with DEBUG

Reported by: pdziepak Owned by: pdziepak
Priority: normal Milestone: Unscheduled
Component: File Systems/UserlandFS Version: R1/alpha3
Keywords: gsoc2012 Cc:
Blocked By: Blocking:
Platform: All


In debug mode GCC2 doesn't remove unused static inline functions, this causes linking errors in userlandfs server.

The solution is borrowed from Unused but required functions are present with empty implementations or linked using kernelland_emu.

Attachments (1)

userlandfs_debug.patch (2.6 KB ) - added by pdziepak 10 years ago.

Download all attachments as: .zip

Change History (7)

by pdziepak, 10 years ago

Attachment: userlandfs_debug.patch added

comment:1 by pdziepak, 10 years ago

patch: 01

comment:2 by bonefish, 9 years ago

I don't really like this solution. The server should avoid private kernel headers and it does save for <Notifications.h> to handle the NodeMonitoringEventRequest. It should instead rather delegate the invocation of the listener hook to the respective kernel interface library.

Regarding coding style: The } doesn't go on the same line as the {, even if the function body is empty. Exceptions may be made for lists of reserved methods to avoid unnecessarily bloating the source file (e.g., but then the whole function definition is on the same line.

comment:3 by mmadia, 9 years ago

Owner: changed from bonefish to pdziepak
Status: newassigned

comment:4 by pulkomandy, 7 years ago

The patch doesn't work anymore, as the scheduler has changed a bit and it provides some of those inlined functions.

I think I don't understand the FS code well enough to do anything here to implement what Ingo suggests, unless given more details. So help fixing this would be very welcome.

comment:5 by waddlesplash, 6 years ago

Milestone: R1Unscheduled

BeOS did not have UserlandFS, moving out of R1

comment:6 by pulkomandy, 5 years ago

patch: 10
Note: See TracTickets for help on using tickets.