Opened 12 years ago

Closed 11 years ago

#8566 closed bug (fixed)

[notification_server] use close button from Web+

Reported by: diver Owned by: leavengood
Priority: normal Milestone: R1
Component: Servers/notification_server Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

​http://webpositive.haiku-os.org/browser/webkit/trunk/WebKit/haiku/WebPositive/tabview/TabManager.cpp?rev=580#L619

​http://cgit.haiku-os.org/haiku/tree/src/servers/notification/AppGroupView.cpp#n80

Attachments (3)

notification.png​ (30.0 KB ) - added by diver 11 years ago.
notification_mockup.png​ (14.7 KB ) - added by diver 11 years ago.
notification_changes.png​ (38.5 KB ) - added by leavengood 11 years ago.
A real screenshot of experimental changes

Download all attachments as: .zip

Change History (12)

comment:1 by X512, 12 years ago

I think that remove cross button in all cases is a better solution :) Cross for Windows and rectangle for Haiku. See BeZilla.

Last edited 12 years ago by X512 (previous) (diff)

comment:2 by pulkomandy, 11 years ago

Done in hrev44765.

Using a rectangle does not make it clear that it is a "close" button, so I'd rather avoid it ?

Last edited 11 years ago by diver (previous) (diff)

comment:3 by pulkomandy, 11 years ago

Resolution: → fixed
Status: new → closed

comment:4 by diver, 11 years ago

Resolution: fixed
Status: closed → reopened

There is a regression, though: Label in AppGroupView appears 2 pixels higher than before:

While I'm at it I'd like to propose some improvements:

  1. Move label 2 pixels lower as it was before
  2. Add pressed state to close widget.
  3. Don't show 2 close buttons in case of a single notification.
  4. Change AppGroupView height to match Deskbar leaf button height

by diver, 11 years ago

Attachment: notification.png​ added

by diver, 11 years ago

Attachment: notification_mockup.png​ added

comment:5 by leavengood, 11 years ago

+1 to diver's last mockup.

comment:6 by axeld, 11 years ago

You know, flat is modern nowadays ;-)

by leavengood, 11 years ago

Attachment: notification_changes.png​ added

A real screenshot of experimental changes

comment:7 by leavengood, 11 years ago

I have started working on implementing diver's mock-up, and here is what it looks like:

A real screenshot of experimental changes

What do you think diver?

comment:8 by leavengood, 11 years ago

Owner: changed from pulkomandy to leavengood
Status: reopened → in-progress

Take ownership.

comment:9 by leavengood, 11 years ago

Resolution: → fixed
Status: in-progress → closed

OK, this has been committed in hrev45349.

Note: See TracTickets for help on using tickets.