NetPositive don't start anymore

[X512]

This is hrev44133

Tracker says that following symbol is not found:

encode_base64__FPcT0x

[diver]

hrev43382/hrev43383 might be responsible for this.

[czeidler]

actually I don't know, is export not needed?

[jackburton]

You have to add 'extern "C"' in the function declaration, now that the code is contained in a cpp file.

[anevilyak]

hrev43383 is the culprit indeed, assigning to Axel.

[X512]

As I understand NetPositive requires C++ version of encode_base64, not 'extern "C"'. NetPositive with libmail.so from BeOS is working.

[anevilyak]

Looking further, R5's mail kit's declaration for encode_base64() does not have the headerMode parameter that ours does. Nor do we declare an equivalent or an extern symbol matching that one. Could be the problem, but what's puzzling is that it's been this way for ages, and Axel's commit didn't change that AFAICT.

[waddlesplash]

This is still a problem. Neither NetPositive nor BeOS Mail works because of missing decode/encode base64 functions.

[pulkomandy]

(In #10403) The encode_base64 issue is #8579. Please open a dedicated ticket for each remaining issue (if any), that will be simpler to track.

[pulkomandy]

Fixed in hrev46905. It now hits memory corruption when trying to access a website, however.