Terminal: merge in improvements from FonzoTerm fork

[tidux]

FonzoTerm is a fork of Terminal that has improved ANSI arrow handling, improved ANSI color handling, 256 color support, and better default color schemes. I have patches to merge those improvements back into Terminal, while keeping the Terminal branding, signature, icon, etc.

[siarzhuk]

I can overview it in details in some weeks. Quick overview: IMO adding special "ANSI keys" option is not a good way to fix the problem. I suspect we have problem with our termcap definitions but not in Temrinal. The xterm vs xterm-color issue was discussed some times and was rejected because "xterm-color gives us no additional features". Default coloring theme is also very user specific thing to change it to one preferred by part of users. We need more consistent support of color schemes instead of hard-coding it.

[arfonzo]

Hi all.

tidux, thanks for submitting my changes.

Replying to siarzhuk:

I can overview it in details in some weeks. Quick overview: IMO adding special "ANSI keys" option is not a good way to fix the problem. I suspect we have problem with our termcap definitions but not in Temrinal. The xterm vs xterm-color issue was discussed some times and was rejected because "xterm-color gives us no additional features". Default coloring theme is also very user specific thing to change it to one preferred by part of users. We need more consistent support of color schemes instead of hard-coding it.

I agree on all of these points--that's why FonzoTerm is a separate app--not everyone wants BRIGHT instead of BOLD, for example. Additionally:

• ANSI keys option doesn't do anything. That's an artefact from my hacking around that can be removed.
• Termcap definitions are not right--correct. There is another termcap included with FonzoTerm but it's also not 100%. The proper fix for terminal behavior will require termcap changes, whatever they may be.

Kind regards, arfonzo

[tidux]

I'm trying one of the Alpha 4 builds, and if nothing else, can we merge the better color handling from FonzoTerm? It's still awful in Terminal.

[siarzhuk]

Replying to tidux:

I'm trying one of the Alpha 4 builds, and if nothing else, can we merge the better color handling from FonzoTerm? It's still awful in Terminal.

Colors are subject of personal preferences - so easy changing it may disappoint someone else in the community. IMO the right way is supporting more customization possibilities for color sets. Current colors set was selected intentionally and there were some attempts to "improve" it to more "standard" one. All of them were rolled back. Colors are only top of the iceberg of problems in our current Terminal implementation. Many things should be fixed before we can fix colors. :-(

[siarzhuk]

Note: Well, most of proposed changes are implemented/obsoleted by hrev45364. The only left one is ANSI keys support.

[siarzhuk]

Ups... #8482 is about lack of ANSI keys too so this one can be closed.