Opened 8 years ago

Closed 8 years ago

#8732 closed enhancement (fixed)

Terminal: merge in improvements from FonzoTerm fork

Reported by: tidux Owned by: siarzhuk
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/Development
Keywords: Cc: art@…
Blocked By: Blocking:
Platform: All

Description

FonzoTerm is a fork of Terminal that has improved ANSI arrow handling, improved ANSI color handling, 256 color support, and better default color schemes. I have patches to merge those improvements back into Terminal, while keeping the Terminal branding, signature, icon, etc.

Attachments (10)

AppearPrefView.cpp.patch (1.3 KB ) - added by tidux 8 years ago.
AppearPrefView.h.patch (111 bytes ) - added by tidux 8 years ago.
Changelog.patch (1002 bytes ) - added by tidux 8 years ago.
Colors.cpp.patch (212 bytes ) - added by tidux 8 years ago.
PrefHandler.cpp.patch (805 bytes ) - added by tidux 8 years ago.
Shell.cpp.patch (88 bytes ) - added by tidux 8 years ago.
TermConst.h.patch (69 bytes ) - added by tidux 8 years ago.
TermParse.cpp.patch (4.4 KB ) - added by tidux 8 years ago.
TermView.cpp.patch (1.1 KB ) - added by tidux 8 years ago.
VTkeymap.h.patch (677 bytes ) - added by tidux 8 years ago.

Download all attachments as: .zip

Change History (19)

by tidux, 8 years ago

Attachment: AppearPrefView.cpp.patch added

comment:1 by tidux, 8 years ago

patch: 01

by tidux, 8 years ago

Attachment: AppearPrefView.h.patch added

by tidux, 8 years ago

Attachment: Changelog.patch added

by tidux, 8 years ago

Attachment: Colors.cpp.patch added

by tidux, 8 years ago

Attachment: PrefHandler.cpp.patch added

by tidux, 8 years ago

Attachment: Shell.cpp.patch added

by tidux, 8 years ago

Attachment: TermConst.h.patch added

by tidux, 8 years ago

Attachment: TermParse.cpp.patch added

by tidux, 8 years ago

Attachment: TermView.cpp.patch added

by tidux, 8 years ago

Attachment: VTkeymap.h.patch added

comment:2 by siarzhuk, 8 years ago

I can overview it in details in some weeks. Quick overview: IMO adding special "ANSI keys" option is not a good way to fix the problem. I suspect we have problem with our termcap definitions but not in Temrinal. The xterm vs xterm-color issue was discussed some times and was rejected because "xterm-color gives us no additional features". Default coloring theme is also very user specific thing to change it to one preferred by part of users. We need more consistent support of color schemes instead of hard-coding it.

comment:3 by siarzhuk, 8 years ago

Owner: changed from jackburton to siarzhuk
Status: newassigned

in reply to:  2 comment:4 by arfonzo, 8 years ago

Hi all.

tidux, thanks for submitting my changes.

Replying to siarzhuk:

I can overview it in details in some weeks. Quick overview: IMO adding special "ANSI keys" option is not a good way to fix the problem. I suspect we have problem with our termcap definitions but not in Temrinal. The xterm vs xterm-color issue was discussed some times and was rejected because "xterm-color gives us no additional features". Default coloring theme is also very user specific thing to change it to one preferred by part of users. We need more consistent support of color schemes instead of hard-coding it.

I agree on all of these points--that's why FonzoTerm is a separate app--not everyone wants BRIGHT instead of BOLD, for example. Additionally:

  • ANSI keys option doesn't do anything. That's an artefact from my hacking around that can be removed.
  • Termcap definitions are not right--correct. There is another termcap included with FonzoTerm but it's also not 100%. The proper fix for terminal behavior will require termcap changes, whatever they may be.

Kind regards, arfonzo

comment:5 by arfonzo, 8 years ago

Cc: art@… added

comment:6 by tidux, 8 years ago

I'm trying one of the Alpha 4 builds, and if nothing else, can we merge the better color handling from FonzoTerm? It's still awful in Terminal.

in reply to:  6 comment:7 by siarzhuk, 8 years ago

Replying to tidux:

I'm trying one of the Alpha 4 builds, and if nothing else, can we merge the better color handling from FonzoTerm? It's still awful in Terminal.

Colors are subject of personal preferences - so easy changing it may disappoint someone else in the community. IMO the right way is supporting more customization possibilities for color sets. Current colors set was selected intentionally and there were some attempts to "improve" it to more "standard" one. All of them were rolled back. Colors are only top of the iceberg of problems in our current Terminal implementation. Many things should be fixed before we can fix colors. :-(

comment:8 by siarzhuk, 8 years ago

Note: Well, most of proposed changes are implemented/obsoleted by hrev45364. The only left one is ANSI keys support.

comment:9 by siarzhuk, 8 years ago

Resolution: fixed
Status: assignedclosed

Ups... #8482 is about lack of ANSI keys too so this one can be closed.

Note: See TracTickets for help on using tickets.