Opened 7 years ago

Closed 7 years ago

#8773 closed bug (fixed)

Keymap preferences resets state of lock keys

Reported by: jessicah Owned by: axeld
Priority: normal Milestone: R1
Component: Preferences/Keymap Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

When opening KeyMap preferences or when choosing a new layout, the state of the lock keys get reset. However, this is not indicated in the UI nor with the keyboard indicators themselves.

The keyboard indicators only change after pressing a key.

Attached a patch that will preserve the state of the lock keys.

Attachments (2)

keymap.patch (474 bytes ) - added by jessicah 7 years ago.
preserve lock keys status when setting keymap
0001-Preserve-state-of-lock-keys-when-keymap-is-loaded.patch (820 bytes ) - added by jessicah 7 years ago.

Download all attachments as: .zip

Change History (6)

by jessicah, 7 years ago

Attachment: keymap.patch added

preserve lock keys status when setting keymap

comment:1 by jessicah, 7 years ago

Has a Patch: set

comment:2 by axeld, 7 years ago

Nice catch! Thanks for the patch, it looks good as is. Could you redo it using git formatpatch? In any case, I'll try to apply it next week, so if you don't have the time, don't bother.

comment:3 by jessicah, 7 years ago

Updated patch using git format-patch. It would be helpful if the documentation for Submitting Patches is updated to reflect that :)

comment:4 by korli, 7 years ago

Resolution: fixed
Status: newclosed

Applied, thanks! Documentation for 'Submitting Patches' tracked in #8822

Note: See TracTickets for help on using tickets.