font size change causes menu text truncating when it isn't needed

[luroh]

1. Open Preferences -> Appearance -> Fonts and increase the 'Plain font' size to 14.
2. Open ActivityMonitor and press the 'Settings' menu and note that the menu text reads 'Sett...s...'.

3. Move the mouse pointer down the menu and note that it changes to the correct text, 'Settings...'.

Similar menu text corruption can be found in other applications as well, e.g. in CharacterMap and GLTeapot.

[anevilyak]

Note: have verified with luroh that hrev44458 is not responsible, this dates back to Alpha 3 or earlier.

[leavengood]

And in this case you aren't even changing the menu font, just the normal font, eh?

So it is almost like the menu text rendering is truncating the text (hence the ellipsis) because it thinks there is not enough room. But it is weird that it then looks right when hovered. Checking the code for MenuItem I see that it does truncate in the middle if it thinks there is not enough room. I suspect something is wonky in BMenuItem::GetContentSize(). But this isn't corruption of the menu text, just truncating, so I'm changing the Summary.

[luroh]

Replying to leavengood:

And in this case you aren't even changing the menu font, just the normal font, eh?

Correct. Increasing the 'Plain font' size somehow affects also the menus.

[leavengood]

I'm not exactly sure why setting the main font bigger caused this to show up, but it seems to just be a good old off-by-one error. Should be fixed in hrev44466.

[leavengood]

With Rene's help I dug into this more and fixed another part of this bug in hrev44467. What was fixed there is why changing the main font caused the truncation to appear.