Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#8881 closed enhancement (fixed)

[Backgrounds] add support for color drops

Reported by: diver Owned by: korli
Priority: normal Milestone: R1
Component: Preferences/Backgrounds Version: R1/Development
Keywords: gci2014 Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description (last modified by pulkomandy)

The Backgrounds preferences should accept color drops (from Colors! or other similar apps) just like the desktop background itself does.

Attachments (2)

0001-Fix-8881-Add-color-drops-to-Backgrounds.patch (3.3 KB ) - added by TwoFx 5 years ago.
0001-Fix-8881-Add-color-drops-to-Backgrounds.2.patch (3.4 KB ) - added by TwoFx 5 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by Giova84, 5 years ago

If I correctly understand, currently color drops works fine on Haiku: eg If I drop a color from the application "Colors!" to the Desktop, this will change the background color. However if i do this operation while the Background preflet is open, the preview isn't updated.

Ok: I have confused "background" with "Backgrounds" (the app), sorry for the noise :-)

Last edited 5 years ago by Giova84 (previous) (diff)

comment:2 by pulkomandy, 5 years ago

Description: modified (diff)

Added a description to the ticket so it is more clear :)

comment:3 by TwoFx, 5 years ago

I wrote a patch that should address everything that was discussed here.

comment:4 by TwoFx, 5 years ago

Has a Patch: set

comment:5 by korli, 5 years ago

I think that BackgroundsApplication::MessageReceived() should only forward the dropped message if it contains a "RGBColor" data of type B_RGB_COLOR_TYPE. One could drop something else and be handled later in the method.

in reply to:  5 comment:6 by TwoFx, 5 years ago

Replying to korli:

I think that BackgroundsApplication::MessageReceived() should only forward the dropped message if it contains a "RGBColor" data of type B_RGB_COLOR_TYPE. One could drop something else and be handled later in the method.

You are right.

comment:7 by TwoFx, 5 years ago

Has a Patch: unset

comment:8 by TwoFx, 5 years ago

Has a Patch: set

comment:9 by korli, 5 years ago

Resolution: fixed
Status: newclosed

Patch applied in rev48589. Thanks!

comment:10 by korli, 5 years ago

Keywords: gci2014 added
Note: See TracTickets for help on using tickets.