Opened 7 years ago

Closed 7 years ago

#9129 closed enhancement (fixed)

[PATCH] Terminal: Use brighter colors instead of bold.

Reported by: js Owned by: siarzhuk
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This patch renders bold text brighter instead of using a bold font, as currently, the rendering of a bold font is done by rendering it twice (the second time with an x offset of 1), which makes letters like m look like a block. Many other terminals do the same.

Attachments (1)

0001-Terminal-Use-brighter-colors-instead-of-bold.patch (1.6 KB ) - added by js 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by js, 7 years ago

Has a Patch: set

comment:2 by js, 7 years ago

Type: bugenhancement

comment:3 by siarzhuk, 7 years ago

Owner: changed from jackburton to siarzhuk
Status: newassigned

comment:4 by axeld, 7 years ago

It looks like something like this already made it into the repository. For the record, I don't like that rendering; bold is used in our default colored 'ls' for many things, and the colors look just bad in comparison to what we had before.

Maybe we could make it an option instead? Also, since it's bold, I think heavier/darker colors would make more sense to use instead of brighter ones.

Also, maybe there is a terminal font that keeps the same width for its bold variant?

in reply to:  4 comment:5 by siarzhuk, 7 years ago

Replying to axeld:

It looks like something like this already made it into the repository. For the record, I don't like that rendering; bold is used in our default colored 'ls' for many things, and the colors look just bad in comparison to what we had before.

Yep, current implementation is inconsistent at least with xterm, Konsole and XFCE Terminal. In my opinion, as we are on GUI OS - there are no reasons to fake bold with brighter colors.

BTW, I'm trying to improve a bit our Terminal application:

  • actualize termcap to most actual version converted from ncurses' terminfo.src;
  • switch to TERM = "xterm-256color" that looks like modern version of xterm we have to support nowadays;
  • implement Background Colors Erasing that is "must have" feature for xterm/xterm-256color emulation and alternate screen buffer applications like Midnight Commander;
  • Restore the Foreground/Background colors configurability and do not link it to ANSI 0/7 colors;
  • etc, etc, etc...

My Sandbox repository is here: https://gitorious.org/sz-sandbox/terminal and most of the list above is already fixed in it. ;-) At least my MC build has no issues with it.

in reply to:  4 comment:6 by siarzhuk, 7 years ago

Replying to axeld:

Maybe we could make it an option instead? Also, since it's bold, I think heavier/darker colors would make more sense to use instead of brighter ones.

By the way, I have implemented R5-like bold rendering, may be it can be more cute than previous way, who knows. But I agree with you - making such features configurable has a big reasons to be implemented. Looks like some users are "living" in Terminal so they have right to adjust it more precisely, IMO. ;-)

comment:7 by siarzhuk, 7 years ago

Please check versions after hrev45364 and drop the note if you not satisfied and still need the coloring way of bold character rendering.

comment:8 by siarzhuk, 7 years ago

Resolution: fixed
Status: assignedclosed

If you find seamless way to add this feature into current implementation - feel free to provide the patch.

Note: See TracTickets for help on using tickets.