Bluetooth UI Improvements

[TriEdgeAI]

Ticket for Google Code-In task: ​https://google-melange.appspot.com/gci/task/view/google/gci2012/7975202

Fixed some code style issues. Added an icon, StringView and device name. I think I fixed the closing bug (or was there a bug in the first place?). Other minor changes. I wasn't able to launch it with a proper bluetooth device, though, so I am blindly using GetFriendlyName(). That part might not work properly.

[stippi]

Hi TriEdgeAI!

thanks for working on this! Instead of attaching the files directly, can you use git to create a proper patch? See SubmittingPatches for how this is done. Otherwise I don't understand where stuff goes, what are new files, what are changed files and how exactly and which parts of the code you changed. Thanks a lot!

[TriEdgeAI]

Hey, stippi, You are correct. Sorry for the trouble. I made a patch that includes new files and changes. :) You can delete all the attachments I uploaded, I am attaching the patch now.. Best regards.

[oruizdorantes]

Discussion following on GCI task page/mail

[modeenf]

So what happend to the GCI projects? :)

[mmadia]

Hi TriEdgeAl. Would you recreate this patch with ​git format-patch? This will give you a better level of recognition for your contribution. Thanks!

[mmadia]

On ​TriEdgeAl's Google Drive, there's another similarly named patch. However, the contents are different. Which patch(es) should be applied?

[mmadia]

With bluetooth-settings-3.patch and bluetooth-deviceclass-1.patch applied (Provided by oruizdorantes, from different GCI2012 tasks), attachment:bluetoothUI-v2.patch​ applies, but fails to compile.

GCC 2:

/generated/x86gcc2> jam -q Bluetooth
LLVM not available on GCC2 
...patience...
...found 7766 target(s)...
...updating 3 target(s)...
Link /generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/libbluetooth.so 
/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/PincodeWindow.o: In function `Bluetooth::PincodeWindow::InitUI(void)':
PincodeWindow.cpp:(.text+0x33c): undefined reference to `Bluetooth::BluetoothIconView::BluetoothIconView(void)'
/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/ConnectionIncoming.o: In function `Bluetooth::ConnectionIncoming::ConnectionIncoming(bdaddr_t)':
ConnectionIncoming.cpp:(.text+0x103): undefined reference to `Bluetooth::ConnectionView::ConnectionView(BRect, BString, BString)'
/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/ConnectionIncoming.o: In function `Bluetooth::ConnectionIncoming::ConnectionIncoming(Bluetooth::RemoteDevice *)':
ConnectionIncoming.cpp:(.text+0x2e7): undefined reference to `Bluetooth::ConnectionView::ConnectionView(BRect, BString, BString)'
ConnectionIncoming.cpp:(.text+0x3a7): undefined reference to `Bluetooth::ConnectionView::ConnectionView(BRect, BString, BString)'
collect2: ld returned 1 exit status

rm -f "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/libbluetooth.so"
/boot/develop/abi/x86/gcc2/tools/current/bin/gcc -pipe -nostart -Xlinker -soname="libbluetooth.so" -nostdlib -Xlinker --no-undefined -o "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/libbluetooth.so"  "/generated/x86gcc2/objects/haiku/x86/release/system/glue/arch/x86/crti.o" "/boot/develop/abi/x86/gcc2/tools/gcc-2.95.3-haiku-121101/lib/gcc-lib/i586-pc-haiku/2.95.3-haiku-121101/crtbegin.o" "/generated/x86gcc2/objects/haiku/x86/release/system/glue/init_term_dyn.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/LocalDevice.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/DiscoveryListener.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/DiscoveryAgent.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/RemoteDevice.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/CommandManager.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/KitSupport.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/DeviceClass.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/PincodeWindow.o" "/generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/ConnectionIncoming.o" \
"/generated/x86gcc2/objects/haiku/x86/release/kits/libbe.so" "/generated/x86gcc2/objects/haiku/x86/release/kits/locale/liblocalestub.a" "/generated/x86gcc2/objects/haiku/x86/release/libs/stdc++/legacy/libstdc++.r4.so" "/generated/x86gcc2/objects/haiku/x86/release/system/libroot/libroot.so"  "/boot/develop/abi/x86/gcc2/tools/gcc-2.95.3-haiku-121101/lib/gcc-lib/i586-pc-haiku/2.95.3-haiku-121101/crtend.o" "/generated/x86gcc2/objects/haiku/x86/release/system/glue/arch/x86/crtn.o" \


...failed Link /generated/x86gcc2/objects/haiku/x86/release/kits/bluetooth/libbluetooth.so ...

BUILD FAILURE:
...failed updating 1 target(s)...
...skipped 1 target(s)...
/generated/x86gcc2> 

GCC 4:

/generated/x86gcc4> jam -q Bluetooth
...patience...
...found 7763 target(s)...
...updating 6 target(s)...
C++ /generated/x86gcc4/objects/haiku/x86/release/kits/bluetooth/ConnectionIncoming.o 
In file included from /use-the-source/haiku/headers/private/bluetooth/ConnectionIncoming.h:17:0,
                 from /use-the-source/haiku/src/kits/bluetooth/UI/ConnectionIncoming.cpp:10:
/use-the-source/haiku/headers/private/bluetooth/ConnectionView.h:28:7: error: extra qualification 'Bluetooth::ConnectionView::' on member 'ConnectionView' [-fpermissive]
/use-the-source/haiku/src/kits/bluetooth/UI/ConnectionIncoming.cpp:33:68: error: default argument given for parameter 1 of 'Bluetooth::ConnectionIncoming::ConnectionIncoming(Bluetooth::RemoteDevice*)' [-fpermissive]
/use-the-source/haiku/headers/private/bluetooth/ConnectionIncoming.h:35:7: error: after previous specification in 'Bluetooth::ConnectionIncoming::ConnectionIncoming(Bluetooth::RemoteDevice*)' [-fpermissive]

/boot/develop/abi/x86/gcc4/tools/current/bin/gcc -c "/use-the-source/haiku/src/kits/bluetooth/UI/ConnectionIncoming.cpp" -O2 -Wall -Wno-trigraphs -Wno-ctor-dtor-privacy -Woverloaded-virtual -Wpointer-arith -Wcast-align -Wsign-compare -Wno-multichar -pipe -fno-strict-aliasing -nostdinc -Wno-deprecated -march=pentium -D_ZETA_USING_DEPRECATED_API_=1 -D_ZETA_TS_FIND_DIR_=1 -Werror -Wno-error=uninitialized -Wno-unused-but-set-variable -D__HAIKU__ -DHAIKU_DISTRO_COMPATIBILITY_DEFAULT -D__INTEL__ -DARCH_x86 -DBOOT_ARCHIVE_IMAGE_OFFSET=300 -DB_USE_BUILTIN_ATOMIC_FUNCTIONS -DHAIKU_INCLUDE_PATENTED_CODE=0 -DHAIKU_TARGET_PLATFORM_HAIKU -iquote /use-the-source/haiku/build/user_config_headers -iquote /use-the-source/haiku/build/config_headers -iquote /use-the-source/haiku/src/kits/bluetooth -iquote /generated/x86gcc4/objects/common/kits/bluetooth -iquote /generated/x86gcc4/objects/haiku_host/x86/common/kits/bluetooth -iquote /generated/x86gcc4/objects/haiku/x86/common/kits/bluetooth -iquote /use-the-source/haiku/src/kits/bluetooth/UI -iquote /use-the-source/haiku/src/kits/bluetooth/UI -I /use-the-source/haiku/headers/private/shared -I /use-the-source/haiku/headers/private/bluetooth -I /boot/develop/abi/x86/gcc4/tools/gcc-4.6.3-haiku-121101/lib/gcc/i586-pc-haiku/4.6.3/../../../../include/c++/4.6.3 -I /boot/develop/abi/x86/gcc4/tools/gcc-4.6.3-haiku-121101/lib/gcc/i586-pc-haiku/4.6.3/../../../../include/c++/4.6.3/i586-pc-haiku -I /boot/develop/abi/x86/gcc4/tools/gcc-4.6.3-haiku-121101/lib/gcc/i586-pc-haiku/4.6.3/../../../../include/c++/4.6.3/backward -I /boot/develop/abi/x86/gcc4/tools/gcc-4.6.3-haiku-121101/lib/gcc/i586-pc-haiku/4.6.3/../../../../include/c++/4.6.3/ext -I /boot/develop/abi/x86/gcc4/tools/gcc-4.6.3-haiku-121101/lib/gcc/i586-pc-haiku/4.6.3/include -I /boot/develop/abi/x86/gcc4/tools/gcc-4.6.3-haiku-121101/lib/gcc/i586-pc-haiku/4.6.3/include-fixed -I /use-the-source/haiku/headers -I /use-the-source/haiku/headers/posix -I /use-the-source/haiku/headers/glibc -I /use-the-source/haiku/headers/os -I /use-the-source/haiku/headers/os/add-ons -I /use-the-source/haiku/headers/os/add-ons/file_system -I /use-the-source/haiku/headers/os/add-ons/graphics -I /use-the-source/haiku/headers/os/add-ons/input_server -I /use-the-source/haiku/headers/os/add-ons/registrar -I /use-the-source/haiku/headers/os/add-ons/screen_saver -I /use-the-source/haiku/headers/os/add-ons/tracker -I /use-the-source/haiku/headers/os/app -I /use-the-source/haiku/headers/os/device -I /use-the-source/haiku/headers/os/drivers -I /use-the-source/haiku/headers/os/game -I /use-the-source/haiku/headers/os/interface -I /use-the-source/haiku/headers/os/kernel -I /use-the-source/haiku/headers/os/locale -I /use-the-source/haiku/headers/os/media -I /use-the-source/haiku/headers/os/mail -I /use-the-source/haiku/headers/os/midi -I /use-the-source/haiku/headers/os/midi2 -I /use-the-source/haiku/headers/os/net -I /use-the-source/haiku/headers/os/opengl -I /use-the-source/haiku/headers/os/storage -I /use-the-source/haiku/headers/os/support -I /use-the-source/haiku/headers/os/translation -I /use-the-source/haiku/headers/private/. -o "/generated/x86gcc4/objects/haiku/x86/release/kits/bluetooth/ConnectionIncoming.o" ;

...failed C++ /generated/x86gcc4/objects/haiku/x86/release/kits/bluetooth/ConnectionIncoming.o ...

BUILD FAILURE:
...failed updating 1 target(s)...
...skipped 2 target(s)...
/generated/x86gcc4> 

Removing all objects prior to jamming Bluetooth does not help.

[TriEdgeAI]

Hmm.. personally I don't care about being credited or not in the patch, but since there are compile errors, too, I guess I will look into creating a proper revision of the patch. I am a bit busy now, so I suppose providing the patch tomorrow is OK?

[mmadia]

Sure! I may not be able to check it for compile errors, push it until later in the week though.

[mmadia]

TriEdgeAI, do you have any interest in working on this? I'm looking into ways of having Bluetooth added to the default images as a non-activated HPKG, which would make these improvements more visible.

[TriEdgeAI]

Sorry, I won't be having any time :(

[Freeman]

What would you like to be added to the code?

[waddlesplash]

The Bluetooth UI has been greatly improved since this ticket was opened; closing.