Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9399 closed enhancement (fixed)

FirstBootPrompt fallout from #8945/hrev45185

Reported by: luroh Owned by: mmadia
Priority: normal Milestone: R1
Component: Applications/FirstBootPrompt Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

hrev45189, gcc2.

I hadn't run Haiku for a while and was surprised to see the ReadOnlyBootPrompt appearing when booting a vmware image or an image built straight to a partition. A quick search led me to #8945 and hrev45185.

1) The ReadOnlyBootPrompt sports two confusingly labeled buttons; 'Run Installer' and 'Desktop (Live-CD)', neither of which seems an appropriate choice for the use cases in question. A single 'Continue' button would be preferable, although just relabeling the second one e.g. 'Boot to desktop' might work too.

2) There is now an Installer icon on my desktop, looking a bit superfluous/unpurposed/déplacé.

3) 'ReadOnlyBootPrompt' seems to have become a misnomer, perhaps it should now be renamed.

Change History (7)

comment:1 by anevilyak, 7 years ago

Owner: changed from stippi to mmadia
Status: newassigned

comment:2 by dsjonny, 7 years ago

I have "re-translated" the strings on Pootle, and for Hungarian the buttons and the text is fit to the function for the app.

in reply to:  2 comment:3 by mmadia, 7 years ago

Status: assignedin-progress

Hrmm... I didn't consider those points.

  1. The button "Desktop (Live-CD)" is renamed to "Boot to Desktop"
  2. The Installer icon will only be copied to the Desktop on read-only medium.
  3. "ReadOnlyBootPrompt" is renamed to "FirstBootPrompt"

Replying to dsjonny:

I have "re-translated" the strings on Pootle, and for Hungarian the buttons and the text is fit to the function for the app.

IIRC it's better to update the text in the source code, as opposed to having the localized text mean something else.

comment:4 by axeld, 7 years ago

To Matt: sounds good!

comment:5 by mmadia, 7 years ago

Component: Applications/ReadOnlyBootPromptApplications/FirstBootPrompt

Modifying ticket to reflect the renaming of ReadOnlyBootPrompt to FirstBootPrompt.

comment:6 by mmadia, 7 years ago

Resolution: fixed
Status: in-progressclosed
Summary: ReadOnlyBootPrompt fallout from #8945/hrev45185FirstBootPrompt fallout from #8945/hrev45185

Updated in hrev45193.

comment:7 by luroh, 7 years ago

Looks good, thanks!

Note: See TracTickets for help on using tickets.