Context Navigation

#9426 closed bug (fixed)

The enable/disable button should really be a checkbox "[_] Enable notifications"

0001-Changed-Enable-notifications-button-to-checkbox.patch (3.6 KB ) - added by Secris 6 years ago.
0001-Changed-notification-button-to-a-checkbox.patch (4.3 KB ) - added by Secris 6 years ago.: Patch with all changes included.
0001-Changed-enable-notification-button-to-a-checkb.patch (4.5 KB ) - added by Secris 6 years ago.: Final patch? Fixes a potential issue with launching the Notification Server twice.

Download all attachments as: .zip

Keywords:	easy added

Keywords:	easy removed
Summary:	Change "Enable notifications" button to checkbox. → Change "Enable notifications" button to checkbox. (easy)

Attachment:	0001-Changed-Enable-notifications-button-to-checkbox.patch added

patch:	0 → 1

There are some more improvements to do:

kServer and fServer are not good names. kToggleNotifications and fNotificationsEnabled may be better (or something like this)
in GenralView::MessageReceived, the action to take depends on _IsServerRunning() only. There is a risk of the checkbox being out of sync. It should decide the action depending on the checkbox state (you can check using the "be:value" field of the message, or using fServer->Value()). If the action is "enable notifications", it should check that the server is not running. If the action is "disable notifications", the current code will show an alert, which sonds right.

I will continue working on this.

Cc:	secris1@… added

Attachment:	0001-Changed-notification-button-to-a-checkbox.patch added

Patch with all changes included.

Attachment:	0001-Changed-enable-notification-button-to-a-checkb.patch added

Final patch? Fixes a potential issue with launching the Notification Server twice.

Resolution:	→ fixed
Status:	new → closed

Applied with some extra style fixes in hrev46979. Thanks for working on this!

Note: See TracTickets for help on using tickets.