Edit source code to remove compilation warnings, to allow -Werror (easy)

[mmadia]

This is a generalized ticket to expose an area to contribute.

Several portions of Haiku's code is not compiled with -Werror. Those portions can be found in ​build/jam/ArchitectureRules.

Some of them only fail on GCC 2 vs. both GCC's. Take care to test with both compilers. As of hrev45297 these are those directories:

#	EnableWerror src add-ons accelerants intel_extreme ;
#	EnableWerror src add-ons accelerants matrox ;
#	EnableWerror src add-ons accelerants nvidia ;
#	EnableWerror src add-ons accelerants radeon ;
#	EnableWerror src add-ons accelerants radeon_hd ;
#	EnableWerror src add-ons input_server filters ;
#	EnableWerror src add-ons input_server methods ;
#	EnableWerror src add-ons kernel bus_managers acpi ;
#	EnableWerror src add-ons kernel bus_managers firewire ;
#	EnableWerror src add-ons kernel bus_managers ps2 ; # gcc2
#	EnableWerror src add-ons kernel debugger ; # gcc2
#	EnableWerror src add-ons kernel drivers audio ;
#	EnableWerror src add-ons kernel drivers graphics ;
#	EnableWerror src add-ons kernel drivers input ;
#	EnableWerror src add-ons kernel drivers network ;
#	EnableWerror src add-ons kernel drivers power ;
#	EnableWerror src add-ons kernel file_systems ext2 ;
#	EnableWerror src add-ons kernel file_systems fat ;
#	EnableWerror src add-ons kernel file_systems googlefs ;
#	EnableWerror src add-ons kernel file_systems ntfs ;
#	EnableWerror src add-ons kernel file_systems reiserfs ;
#	EnableWerror src add-ons kernel network datalink_protocols ;
#	EnableWerror src add-ons kernel network stack ;
#	EnableWerror src add-ons media media-add-ons usb_webcam ;
#	EnableWerror src add-ons media media-add-ons video_producer_demo ;
#	EnableWerror src add-ons media plugins asf_reader ;
#	EnableWerror src add-ons media plugins avi_reader ;
#	EnableWerror src add-ons media plugins ffmpeg ;
#	EnableWerror src add-ons media plugins matroska ;
#	EnableWerror src add-ons media plugins mov_reader ;
#	EnableWerror src add-ons media plugins mp3_reader ;
#	EnableWerror src add-ons media plugins ogg ;
#	EnableWerror src add-ons media plugins raw_decoder ;
#	EnableWerror src add-ons media plugins speex ;
#	EnableWerror src add-ons media plugins wav_reader ;
#	EnableWerror src add-ons translators exr ;
#	EnableWerror src add-ons translators hpgs ;
#	EnableWerror src add-ons translators jpeg ; # gcc2
#	EnableWerror src add-ons translators png ; # gcc2
#	EnableWerror src add-ons translators stxt ;
#	EnableWerror src add-ons translators wonderbrush ;

The process would be:

• Uncomment one of these lines in the ArchitectureRules file,
• Build Haiku
• Compilation will fail because of a compiler warning now being considered an error
• Alter the code to fix the warning
• Submit your change to Gerrit for code review

Mention this ticket in the commit message of your changes (include a line saying "Fixes: #9640") to help us find what your work is related to.

Eventually, all warnings will be fixed and we can enable Werror globally on all our sourcecode.

Note that there are exceptions to this: some code is "vendored", that is, we copied it from other projects. For example, the NTFS driver contains code from the NTFS-3G project. In this case, the fixes should be discussed with the original developers of the code, and made on their project if they accept it, to make it easier for us to merge in later versions of their code. So, if you are new to Haiku and want to help with this, it's better to start from parts of the sourcecode that are not in this situation (ask us if you don't know how to determine this).

[pulkomandy]

I think this makes a good easy task and could be added to the next run of Google Code-In.

[Coldfirex]

Updated list as of hrev55181+55:

#	EnableWerror src add-ons input_server methods pen ;
#	EnableWerror src add-ons kernel bus_managers firewire ;
#	EnableWerror src add-ons kernel debugger ; # gcc2
#	EnableWerror src add-ons kernel drivers audio ;
#	EnableWerror src add-ons kernel drivers bus ;
#	EnableWerror src add-ons kernel drivers disk ;
#	EnableWerror src add-ons kernel drivers graphics ;
#	EnableWerror src add-ons kernel drivers input ;
#	EnableWerror src add-ons kernel drivers network ;
#	EnableWerror src add-ons kernel drivers power ;
#	EnableWerror src add-ons kernel file_systems ext2 ;
#	EnableWerror src add-ons kernel file_systems fat ;
#	EnableWerror src add-ons kernel file_systems googlefs ;
#	EnableWerror src add-ons kernel file_systems netfs ;
#	EnableWerror src add-ons kernel file_systems nfs ;
#	EnableWerror src add-ons kernel file_systems ntfs ;
#	EnableWerror src add-ons kernel file_systems ramfs ;
#	EnableWerror src add-ons kernel file_systems reiserfs ;
#	EnableWerror src add-ons kernel network datalink_protocols ;
#	EnableWerror src add-ons kernel network stack ;
#	EnableWerror src add-ons media media-add-ons usb_webcam ;
#	EnableWerror src add-ons media media-add-ons video_producer_demo ;
#	EnableWerror src add-ons media plugins ffmpeg ;
#	EnableWerror src add-ons media plugins raw_decoder ;
#	EnableWerror src add-ons translators jpeg2000 ;

[cassisian]

Fixed (not all by me):

• src add-ons kernel file_systems ext2 (6)
• src add-ons media media-add-ons video_producer_demo (2)
• src add-ons kernel network stack (4)
• src add-ons kernel network datalink_protocols(5)
• src add-ons media plugins raw_decoder (3)
• src add-ons kernel debugger (9)
• src add-ons kernel drivers power (10)
• src add-ons kernel drivers bus (11)

Fixes for:

• src add-ons media media-add-ons usb_webcam (1)
• src add-ons kernel bus_managers firewire (7)
• src add-ons input_server methods pen (8)

are under review.

(1) ​https://review.haiku-os.org/c/haiku/+/4501

(2) ​https://review.haiku-os.org/c/haiku/+/4504

(3) ​https://review.haiku-os.org/c/haiku/+/4503

(4) ​https://review.haiku-os.org/c/haiku/+/4512 [Quick win, no related warnings]

(5) ​https://review.haiku-os.org/c/haiku/+/4513 [Quick win, no related warnings]

(6) ​https://review.haiku-os.org/c/haiku/+/4453

(7) ​https://review.haiku-os.org/c/haiku/+/4565 [Quick win, no related warnings]

(8) ​https://review.haiku-os.org/c/haiku/+/4566 [Quick win, no related warnings]

(9) ​https://review.haiku-os.org/c/haiku/+/4567

(10) ​https://review.haiku-os.org/c/haiku/+/4568 [Quick win, no related warnings]

(11) ​https://review.haiku-os.org/c/haiku/+/4569 [Quick win, no related warnings]

[Jim906]

Fixed:

src add-ons kernel drivers disk (​https://review.haiku-os.org/c/haiku/+/5284)

[MuhamedEmad]

Hi, is this issue still up for contribution. if yes then I am thinking to start with this line "#EnableWerror src add-ons kernel drivers audio ;" which is line 683. if it's okay then I will start working right away. if not I want a suggestion for an easy task.

[pulkomandy]

Hello,

Yes, there doesn't seem to be any 3rd party code in the "audio" directory, so it will not be a problem to modify the code to fix warnings.

I suggest replacing #EnableWerror src add-ons kernel drivers audio ; by one line for each of the subdirectories of audio, and then work on them one by one. Maybe start with the "null" driver which is very small, so you can make an easy first contribution and make sure everythign is set up correctly for submitting your changes.

Then continue with the other drivers one by one.

Let us know if you need more help with this :)