Opened 11 years ago

Last modified 5 weeks ago

#9460 new enhancement

Edit source code to remove compilation warnings, to allow -Werror (easy) — at Version 8

Reported by: mmadia Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: - General Version: R1/Development
Keywords: GCI Cc:
Blocked By: #12653, #12662, #12663 Blocking:
Platform: All

Description (last modified by pulkomandy)

This is a generalized ticket to expose an area to contribute.

Several portions of Haiku's code is not compiled with -Werror. Those portions can be found in build/jam/ArchitectureRules.

Some of them only fail on GCC 2 vs. both GCC's. Take care to test with both compilers. As of hrev45297 these are those directories:

#	EnableWerror src add-ons accelerants intel_extreme ;
#	EnableWerror src add-ons accelerants matrox ;
#	EnableWerror src add-ons accelerants nvidia ;
#	EnableWerror src add-ons accelerants radeon ;
#	EnableWerror src add-ons accelerants radeon_hd ;
#	EnableWerror src add-ons input_server filters ;
#	EnableWerror src add-ons input_server methods ;
#	EnableWerror src add-ons kernel bus_managers acpi ;
#	EnableWerror src add-ons kernel bus_managers firewire ;
#	EnableWerror src add-ons kernel bus_managers ps2 ; # gcc2
#	EnableWerror src add-ons kernel debugger ; # gcc2
#	EnableWerror src add-ons kernel drivers audio ;
#	EnableWerror src add-ons kernel drivers graphics ;
#	EnableWerror src add-ons kernel drivers input ;
#	EnableWerror src add-ons kernel drivers network ;
#	EnableWerror src add-ons kernel drivers power ;
#	EnableWerror src add-ons kernel file_systems ext2 ;
#	EnableWerror src add-ons kernel file_systems fat ;
#	EnableWerror src add-ons kernel file_systems googlefs ;
#	EnableWerror src add-ons kernel file_systems ntfs ;
#	EnableWerror src add-ons kernel file_systems reiserfs ;
#	EnableWerror src add-ons kernel network datalink_protocols ;
#	EnableWerror src add-ons kernel network stack ;
#	EnableWerror src add-ons media media-add-ons usb_webcam ;
#	EnableWerror src add-ons media media-add-ons video_producer_demo ;
#	EnableWerror src add-ons media plugins asf_reader ;
#	EnableWerror src add-ons media plugins avi_reader ;
#	EnableWerror src add-ons media plugins ffmpeg ;
#	EnableWerror src add-ons media plugins matroska ;
#	EnableWerror src add-ons media plugins mov_reader ;
#	EnableWerror src add-ons media plugins mp3_reader ;
#	EnableWerror src add-ons media plugins ogg ;
#	EnableWerror src add-ons media plugins raw_decoder ;
#	EnableWerror src add-ons media plugins speex ;
#	EnableWerror src add-ons media plugins wav_reader ;
#	EnableWerror src add-ons translators exr ;
#	EnableWerror src add-ons translators hpgs ;
#	EnableWerror src add-ons translators jpeg ; # gcc2
#	EnableWerror src add-ons translators png ; # gcc2
#	EnableWerror src add-ons translators stxt ;
#	EnableWerror src add-ons translators wonderbrush ;

Mention this ticket in your Gerrit change requests, preferably in the "Blocking:" field.

Change History (8)

comment:1 by mmadia, 11 years ago

Description: modified (diff)

comment:2 by waddlesplash, 9 years ago

Milestone: R1Unscheduled

comment:3 by MichaelCrawford, 8 years ago

Blocked By: 12653 added

comment:4 by MichaelCrawford, 8 years ago

Blocked By: 12662 added

comment:5 by MichaelCrawford, 8 years ago

Blocked By: 12663 added

comment:6 by pulkomandy, 4 years ago

Description: modified (diff)
Keywords: GCI added
Summary: Edit source code to remove compilation warnings, to allow -WerrorEdit source code to remove compilation warnings, to allow -Werror (easy)

I think this makes a good easy task and could be added to the next run of Google Code-In.

comment:7 by diver, 3 years ago

Description: modified (diff)

comment:8 by pulkomandy, 3 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.