Changes between Initial Version and Version 2 of Ticket #9481


Ignore:
Timestamp:
Feb 25, 2013, 11:37:27 PM (12 years ago)
Author:
jscipione
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9481

    • Property Patch 01
  • Ticket #9481 – Description

    initial v2  
    1 Because the locking is not-atomic it can cause the app to crash if it is another thread unlocks the looper while this one is trying to use it. This patch fixes the problem for me and I detect no regressions but I'd like someone to take a second look. It was discovered while I was attempting to fix #8539 and is (partially) responsible for causing that bug. Can someone with experience with BMenuBar and BHandler/BLooper take a look at my patch and see if there are any problems with it?
     1Because the locking is not-atomic it can cause the app to crash if another thread detaches the menu bar from the window while this method is trying to use it.
     2
     3The attached patch fixes the problem for me and I detect no regressions but I'd like someone to take a second look. It was discovered while I was attempting to fix #8539 and is (partially) responsible for causing that bug.
     4
     5Can someone with experience with BMenuBar and BHandler/BLooper take a look at my patch and see if there are any problems with it?