BSeparatorItem should draw a vertical line if attached menu layout is B_ITEMS_IN_ROW

[jscipione]

Currently BSeparatorItem always draws a horizontal line under the assumption that the attached menu's layout is B_ITEMS_IN_COLUMN. This assumption, while pretty good, falls down if menu is in B_ITEMS_IN_ROW. In this case the separator should be vertical.

[jackburton]

BSeparatorItem is only meant to be used in B_ITEMS_IN_COLUMN layout, see here: ​http://www.acm.uiuc.edu/bug/Be%20Book/The%20Interface%20Kit/SeparatorItem.html

[pulkomandy]

Making this an enhancement then. Also I think the current result isn't too bad and works well as a separator in -for example - a BMenuBar.

An alternative use for BSeparator in a BMenuBar would be to act similar to our BLayout "glue", so you could have right-aligned items in a menu.

[jscipione]

enhancement is good. This would be pretty easy to implement though if someone was so inclined. I wanted to use a BSeparatorItem to separate the Deskbar Leaf menu from the applications in horizontal mode, but, found that the BSeparatorItem didn't work in B_ITEMS_IN_ROW. I created a custom BMenuItem instead, but, it would be nice if that wasn't necessary.

[jscipione]

Implemented in hrev54179