DriveSetup: integer overflow in slider for partition size

[anevilyak]

Wouldn't it make more sense to just replace the use of atoi() with strtoll()? The cast isn't going to solve the fact that atoi() isn't going to be able to parse that large of a value range and return a correct value to begin with.

[dsjonny]

Maybe duplicate: #9557

[jessicah]

Hmm, okay, I'll change it to strtoll, although the value is in 1MB increments... scary to imagine storage that large!

[jessicah]

Updated patch to use strtoll.

[anevilyak]

Replying to jessicah:

Hmm, okay, I'll change it to strtoll, although the value is in 1MB increments... scary to imagine storage that large!

If that's the case then how were you in fact observing an overflow? The original patch was a no-op since off_t is already 64-bit, so the cast from int to off_t was done by the compiler implicitly anyways.

[jessicah]

You'd think so, but I was printing it out, and it was indeed overflowing. Looks like the implicit cast happened after the multiplication, not before.

[anevilyak]

Oops, missed that detail, it was a long day. Oh well, we're ready for the day > 2PB hard disks hit the market I suppose :)