Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9756 closed enhancement (fixed)

Debugger: Structure images list by path components of entries

Reported by: stippi Owned by: anevilyak
Priority: normal Milestone: Unscheduled
Component: Applications/Debugger Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

It is often too cumbersome to find code in the images list. The list structure is not optimal. Instead of being structured like this:

src/tools/text/TextCode.cpp src/tools/text/Font.cpp src/tools/text/Paragraph.cpp src/tools/brush/Brush.cpp src/tools/brush/Stroke.cpp

It should be structured like this:

src

tools

text

TextCode.cpp Font.cpp Paragraph.cpp

brush

Brush.cpp Stroke.cpp

I.e. it would be much easier to locate a source file and find a method. And then of course the methods would be the final leaf items just like now. But all other entries should be processed, so that common paths are extracted as the item hierarchy.

Change History (5)

comment:1 by anevilyak, 7 years ago

Status: newin-progress
Version: R1/alpha4.1R1/Development

comment:2 by anevilyak, 7 years ago

Resolution: fixed
Status: in-progressclosed

Implemented in hrev45645.

comment:3 by stippi, 7 years ago

Very nice! I tried to check out the changes, but the build fails for me:

C++ generated/objects/haiku/x86/release/apps/debugger/ImageListView.o 
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp: In member function 'void ImageFunctionsView::FunctionsTableModel::SetImageDebugInfo(ImageDebugInfo*)':
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp:137:13: error: 'static int ImageFunctionsView::SourcePathComponentNode::CompareComponents(const ImageFunctionsView::SourcePathComponentNode*, const ImageFunctionsView::SourcePathComponentNode*)' is private
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp:235:32: error: within this context
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp: In member function 'bool ImageFunctionsView::FunctionsTableModel::GetFunctionPath(FunctionInstance*, TreeTablePath&)':
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp:131:13: error: 'static int ImageFunctionsView::SourcePathComponentNode::CompareByComponentName(const BString*, const ImageFunctionsView::SourcePathComponentNode*)' is private
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp:318:33: error: within this context
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp: In member function 'bool ImageFunctionsView::FunctionsTableModel::_AddNextPathComponent(ImageFunctionsView::SourcePathComponentNode*, BString&, FunctionInstance*, LocatableFile*)':
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp:131:13: error: 'static int ImageFunctionsView::SourcePathComponentNode::CompareByComponentName(const BString*, const ImageFunctionsView::SourcePathComponentNode*)' is private
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp:396:30: error: within this context
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp:137:13: error: 'static int ImageFunctionsView::SourcePathComponentNode::CompareComponents(const ImageFunctionsView::SourcePathComponentNode*, const ImageFunctionsView::SourcePathComponentNode*)' is private
src/apps/debugger/user_interface/gui/team_window/ImageFunctionsView.cpp:411:32: error: within this context

Do you work with GCC2 only?

in reply to:  3 comment:4 by anevilyak, 7 years ago

Replying to stippi:

Very nice! I tried to check out the changes, but the build fails for me:

[...]

Do you work with GCC2 only?

Actually, mainly 4, that was simply a case of last minute cleanup that I forgot to test the build after because it was late. Should be fixed in hrev45646 sorry.

comment:5 by stippi, 7 years ago

Thanks for fixing that. Now that I got a chance to see it in action... it is just sooo much better than before. Huge usability boost! Many thanks for implementing that so fast!

Note: See TracTickets for help on using tickets.