Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9791 closed bug (fixed)

fluidsynth RPN fine-tuning range is incorrect

Reported by: Pete Owned by: phoudoin
Priority: normal Milestone: R1
Component: Audio & Video Version: R1/alpha4.1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This undoubtedly has bothered nobody but me, but it is a trivial fix, and probably should be applied. It has always been incorrect in fluidsynth, and still is in the latest source of theirs. I've notified their mailing-list, so hopefully it will get applied before we next update our copy.

The GM MIDI standard (http://www.midi.org/techspecs/midimessages.php#3a) says that the range should be +/- one semitone (+/-100 cents) but it was only +/-50 cents in fluidsynth. As I quite often need to adjust both piano and synth to match an off-tune recording, this caused great ugliness...

A (2 line) patch is attached.

Attachments (1)

0001-adjust-fluidsynth-fine-tuning-range-to-match-standar.patch (1.3 KB) - added by Pete 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by Pete

Has a Patch: set

comment:2 Changed 6 years ago by phoudoin

Owner: changed from nobody to phoudoin
Status: newin-progress

Did fluidsynth guys replied to your notification and confirmed it's a bug? Meanwhile, I'll be glad to apply your patch, though.

comment:3 in reply to:  2 Changed 6 years ago by Pete

Replying to phoudoin:

Did fluidsynth guys replied to your notification and confirmed it's a bug?

Neither confirm nor deny... (:-/) There's been no response to the post on their mailing list yet. (It's not exactly high traffic -- that is still the last post. I'm not subscribed, so I have to check the archive.) I'm sure the fix is correct, though. Both my digital piano and my old MidiMan synth have that scaling, and the link I gave to the GM standard has it that way.

Meanwhile, I'll be glad to apply your patch, though.

Thanks.

comment:4 Changed 6 years ago by phoudoin

Resolution: fixed
Status: in-progressclosed

Patch applied in hrev45742. Thanks.

When Fluidsynth will move to an external package, this patch should be kept in mind, BTW.

comment:5 in reply to:  4 Changed 6 years ago by Pete

Replying to phoudoin:

Patch applied in hrev45742. Thanks.

And thanks back..

When Fluidsynth will move to an external package, this patch should be kept in mind, BTW.

I'll try to keep an eye on it.

Note: See TracTickets for help on using tickets.