Opened 6 years ago

Closed 6 years ago

#9878 closed bug (fixed)

[ICNSTranslator] ICNSLoader.cpp: Memory allocated by 'new[]' should be deallocated by 'delete[]'

Reported by: mt Owned by: nobody
Priority: normal Milestone: R1
Component: Add-Ons/Translators Version: R1/Development
Keywords: ICNSTranslator Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

  • In ICNSLoader::GetIcon(), variable "rowBuff" should be deallocated by 'delete[]'.
  • In ICNSLoader::ICNSLoader(BPositionIO *stream), variable "icnsDataBuffer" should be deallocated by 'delete[]'

Please see attached report.

Attachments (4)

0008-Use-delete-instead-of-delete.patch (1.2 KB ) - added by mt 6 years ago.
Patch
report-VdlzQs.html (40.8 KB ) - added by mt 6 years ago.
Report by Clang Static Analyzer - 1
report-mq2NP5.html (39.4 KB ) - added by mt 6 years ago.
Report by Clang Static Analyzer - 2
report-n99jQw.html (39.9 KB ) - added by mt 6 years ago.
Report by Clang Static Analyzer - 3

Download all attachments as: .zip

Change History (7)

comment:1 by mt, 6 years ago

Has a Patch: set

by mt, 6 years ago

Attachment: report-VdlzQs.html added

Report by Clang Static Analyzer - 1

by mt, 6 years ago

Attachment: report-mq2NP5.html added

Report by Clang Static Analyzer - 2

by mt, 6 years ago

Attachment: report-n99jQw.html added

Report by Clang Static Analyzer - 3

comment:2 by korli, 6 years ago

Applied in hrev45868. Thanks!

comment:3 by korli, 6 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.