Opened 6 years ago

Last modified 3 years ago

#9891 assigned bug

[Storage Kit] SetStringJob.cpp: Called C++ object pointer is null

Reported by: mt Owned by: nobody
Priority: normal Milestone: R1
Component: Kits/Storage Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

In SetStringJob::Do(), if variable "fChild" is NULL, calling fChild->PartitionID() is invalid. Please see attached report.

Attachments (4)

0014-Fix-called-C-object-pointer-is-null.patch (2.4 KB ) - added by mt 6 years ago.
Patch
report-9QlBqW.html (15.4 KB ) - added by mt 6 years ago.
Report by Clang Static Analyzer - 1
report-mq2NP5.html (15.4 KB ) - added by mt 6 years ago.
Report by Clang Static Analyzer - 2
report-n99jQw.html (15.4 KB ) - added by mt 6 years ago.
Report by Clang Static Analyzer - 3

Download all attachments as: .zip

Change History (7)

comment:1 by mt, 6 years ago

Has a Patch: set

by mt, 6 years ago

Attachment: report-9QlBqW.html added

Report by Clang Static Analyzer - 1

by mt, 6 years ago

Attachment: report-mq2NP5.html added

Report by Clang Static Analyzer - 2

by mt, 6 years ago

Attachment: report-n99jQw.html added

Report by Clang Static Analyzer - 3

comment:2 by mmadia, 6 years ago

As mentioned by Axel on the haiku-development list:

Not sure if that patch is needed, but it does introduce a couple of coding style issues:

  • Missing space after 'if'.
  • Superfluous curly braces
  • Else after return

comment:3 by axeld, 3 years ago

Owner: changed from axeld to nobody
Status: newassigned
Note: See TracTickets for help on using tickets.