Opened 6 years ago

Closed 5 years ago

#9904 closed bug (fixed)

[Screen Savers/spider] SpiderSaver.cpp: Called C++ object pointer is null

Reported by: mt Owned by: korli
Priority: normal Milestone: R1
Component: Add-Ons/Screen Savers Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

In SpiderSaver::_DrawInto(), if fQueues[i] is NULL (fails to allocate in _Init()), calling fQueues[i]->Head() and fQueues[i]->Tail() is invalid. Please see attached report.

Attachments (2)

0019-Fix-called-C-object-pointer-is-null.patch (835 bytes) - added by mt 6 years ago.
Patch
report-d3b55a.html (60.6 KB) - added by mt 6 years ago.
Report by Clang Static Analyzer

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by mt

Patch

comment:1 Changed 6 years ago by mt

Has a Patch: set

Changed 6 years ago by mt

Attachment: report-d3b55a.html added

Report by Clang Static Analyzer

comment:2 Changed 6 years ago by korli

There are a few problems with allocations to solve anyway. What can exactly be done when a failure happen on a parameter change? We have already deallocated things for the previous parameter value (no rollback is possible).

comment:3 Changed 5 years ago by pulkomandy

Resolution: fixed
Status: newclosed

Applied in hrev48344.

Note: See TracTickets for help on using tickets.