Opened 6 years ago

Closed 6 years ago

#9982 closed bug (fixed)

[Installer] doesn't quit correctly on alt+w at EULA window

Reported by: diver Owned by: stpere
Priority: normal Milestone: R1
Component: Applications/Installer Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Closing Installer using alt+w while it shows EULA window makes it hang in the Deskbar. Used to work fine in A3.

Attachments (3)

0001-installer-eula-fix.patch (17.1 KB) - added by Freeman 6 years ago.
0001-installer-eula-fix-goes-to-next-window.2.patch (17.4 KB) - added by Freeman 6 years ago.
0001-installer-eula-fix-goes-to-next-window.patch (17.4 KB) - added by Freeman 6 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 6 years ago by stpere

Resolution: fixed
Status: newclosed

should be fixed in hrev46245. Thanks!

comment:2 Changed 6 years ago by diver

Resolution: fixed
Status: closedreopened

The fix was reverted in hrev46248.

comment:3 Changed 6 years ago by diver

Owner: changed from korli to stpere
Status: reopenedassigned

comment:4 Changed 6 years ago by axeld

Should it really quit when closing the window? Wouldn't it make more sense if it would just continue to the application? I mean, there is still Alt-Q to close the application if that's your intent.

comment:5 Changed 6 years ago by diver

As long as it doesn't just hang in Deskbar without any window it should be fine ;-)

comment:6 Changed 6 years ago by siarzhuk

Are there any objections to publish this puzzle as GCI 2013 task? ;-)

comment:7 Changed 6 years ago by pulkomandy

I vote for having it continue with the installation as well. And, yes, let's see what GCI students can come up with.

comment:8 Changed 6 years ago by Freeman

Has a Patch: set

Changed 6 years ago by Freeman

comment:9 Changed 6 years ago by Freeman

Two patches are included. One to fix the original exit bug, the other to open the installation window after the EULA window has been closed. Time to pick...

comment:10 Changed 6 years ago by korli

A few remarks:

  • The line "BString infoText;" in your patches is misaligned.
  • The copyright header seems wrong formatted (missing comma and period).
  • In a .cpp there are two blank lines after the copyright header.
  • Line 7, 9 and 13 of the EULAWindow.h should be also two blank lines.
  • EULAWindow doesn't need member attributes (local variables are OK).

Thanks!

comment:11 Changed 6 years ago by Freeman

Is anyone getting crashes at InstallerApp::MessageReceived()? The current mentor is getting them but I can't replicate the bug.

comment:12 Changed 6 years ago by siarzhuk

Resolution: fixed
Status: assignedclosed

Applied in hrev46670. Thanks.

Note: See TracTickets for help on using tickets.