[Installer] doesn't quit correctly on alt+w at EULA window

[diver]

Closing Installer using alt+w while it shows EULA window makes it hang in the Deskbar. Used to work fine in A3.

[stpere]

should be fixed in hrev46245. Thanks!

[diver]

The fix was reverted in hrev46248.

[axeld]

Should it really quit when closing the window? Wouldn't it make more sense if it would just continue to the application? I mean, there is still Alt-Q to close the application if that's your intent.

[diver]

As long as it doesn't just hang in Deskbar without any window it should be fine ;-)

[siarzhuk]

Are there any objections to publish this puzzle as GCI 2013 task? ;-)

[pulkomandy]

I vote for having it continue with the installation as well. And, yes, let's see what GCI students can come up with.

[Freeman]

Two patches are included. One to fix the original exit bug, the other to open the installation window after the EULA window has been closed. Time to pick...

[korli]

A few remarks:

• The line "BString infoText;" in your patches is misaligned.
• The copyright header seems wrong formatted (missing comma and period).
• In a .cpp there are two blank lines after the copyright header.
• Line 7, 9 and 13 of the EULAWindow.h should be also two blank lines.
• EULAWindow doesn't need member attributes (local variables are OK).

Thanks!

[Freeman]

Is anyone getting crashes at InstallerApp::MessageReceived()? The current mentor is getting them but I can't replicate the bug.

[siarzhuk]

Applied in hrev46670. Thanks.