Opened 6 years ago

Closed 17 months ago

#10079 closed enhancement (fixed)

HaikuDepot doesn't quit when can't access Internet

Reported by: jessicah Owned by: stippi
Priority: low Milestone: R1
Component: Applications/HaikuDepot Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

When HaikuDepot can't access the Internet (I'm behind a proxy server), it doesn't quit.

Attachments (1)

haikudepot.report.txt (10.6 KB) - added by jessicah 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by jessicah

Attachment: haikudepot.report.txt added

comment:1 Changed 5 years ago by luroh

See also #10233.

comment:2 Changed 5 years ago by luroh

I am no longer able to repeat this problem.

comment:3 Changed 5 years ago by luroh

Resolution: fixed
Status: newclosed

I am again able to repeat this problem. :)

comment:4 Changed 5 years ago by luroh

Resolution: fixed
Status: closedreopened

comment:5 Changed 5 years ago by stippi

Priority: normallow
Type: bugenhancement

I tested several times with unplugged cable. Each time HaikuDepot stays in the Deskbar for a short while and then it properly quits. This is due to the tear-down sequence: In its destructor, the Model stops the package populator thread which communicates with the web-app. That thread is waiting for the HTTP services thread to return, and that one blocks on the network request and eventually times out (after about 30 seconds?). It could be possible to change how these threads communicate, they could use BMessages. Then they wouldn't need to wait for each other during teardown, but only if they are not still sharing data structures somehow. In any case, HaikuDepot does not dead-lock, it's just an irritation that it stays in Deskbar a little longer. To reflect that, I am changing ticket properties.

comment:6 Changed 19 months ago by apl-haiku

I suspect that Stephan has diagnosed this problem correctly. Better cancellation behaviour was introduced in 3094fef308a6aaaef9827863a0a99640bdaaa5af; Jessica and luroh could I please ask you to try this issue again and see if the problem has gone away. If so, can you then also close this ticket -- thanks.

Edit; also the application will not attempt to do a "bulk load" if the network is absent.

Last edited 19 months ago by apl-haiku (previous) (diff)

comment:7 Changed 17 months ago by apl-haiku

Resolution: fixed
Status: reopenedclosed

This issue is resolved now.

Note: See TracTickets for help on using tickets.