Opened 10 years ago

Closed 10 years ago

#10223 closed bug (fixed)

Fixed possibly not null-terminated strings

Reported by: Ezodev Owned by: nobody
Priority: normal Milestone: R1
Component: - General Version: R1/Development
Keywords: gci2013 coverity Cc:
Blocked By: Blocking:
Platform: All

Description

If source strings are wrong, this strings will be not null-terminated. I dont know what are this source strings, but this code willn't affect execution speed and will shut-up programs for static analysis.

Attachments (2)

0001-Fixed-possible-not-null-termined-strings.patch​ (1.3 KB ) - added by Ezodev 10 years ago.
0001-Fixed-possible-bug-resulting-in-not-null-terminated-.patch​ (1.1 KB ) - added by Ezodev 10 years ago.

Download all attachments as: .zip

Change History (6)

by Ezodev, 10 years ago

Attachment: 0001-Fixed-possible-not-null-termined-strings.patch​ added

comment:1 by Ezodev, 10 years ago

patch: 0 → 1

comment:2 by bonefish, 10 years ago

The preferred solution would be to simply use strlcpy() instead of strncpy().

BTW, NULL is the null pointer. For the nul character '\0' should be used.

in reply to:  2 comment:3 by Ezodev, 10 years ago

Okay, I changed it. I've never heard of this function before.

by Ezodev, 10 years ago

Attachment: 0001-Fixed-possible-bug-resulting-in-not-null-terminated-.patch​ added

comment:4 by bonefish, 10 years ago

Resolution: → fixed
Status: new → closed

Thanks! Applied in hrev46395.

Note: See TracTickets for help on using tickets.