Changed some dynamic casts to reinterpret casts

[Ezodev]

These dynamic casts wern't checked. Reinterpret cast is instant, dynamic cast is slow. If there is no error checking, dynamic cast gives nothing. It will just cause application crash.

[umccullough]

Per Ezo in IRC, this should resolve CIDs 611227 and 611228 (and possibly others)

[bonefish]

The cast operator you're looking for is static_cast, not reinterpret_cast.

The unchecked dynamic_casts are really intended, though. In all cases the actual type of the object is ensured by other means. A mismatch would be a program error and the immediate crash caused by the NULL pointer would be desirable (a static_cast to a wrong type wouldn't necessarily cause an immediate crash). Performance isn't much of a concern in these cases. I don't know, maybe adding an ASSERT would be cleaner. Or alternatively dereferencing the original pointer and casting the reference (causing an exception on type mismatch).

[Ezodev]

new patch

[Ezodev]

If speed isn't critical, I've added null checking. It's better than crash few lines later, It will call destructors etc. Error code 2 because it's unused and someone can easily track problem in source. And it will silient off tools to static analysis.

[bonefish]

A call to debugger() would be much better than exit()ing in those cases, ideally with a way to recover afterward, if that doesn't need more than a simple return.

As per our coding style guide there should be a space between if and (.

[Ezodev]

I've added calls to debugger(). But I don't understand what you means by way to recover afterward. If this is simply returning from function, I don't know where can I do it without problems.

[Ezodev]

Ups. new patch don't compiling, sorry.

[Ezodev]

Fixed. Is this solution good?

[bonefish]

• Don't use fprintf(). Just call debugger() in all cases. And return afterward.
• String literals should not be wrapped like this. Close the literal at the end of the line and start a new on the next line (indent as usual with one additional tab), like:

  printf("this line is "
  	"too long\n");
  

• Null pointer checks should be spelled explicitly: foo == NULL.

[luroh]

Moving Debugger related tickets out of R1 milestone (Prop #14).