Opened 6 years ago

Closed 6 years ago

#10237 closed bug (fixed)

[PATCH] Fix serialconnect build on x86_64

Reported by: umccullough Owned by: anevilyak
Priority: normal Milestone: R1
Component: Applications Version: R1/Development
Keywords: serialconnect x86_64 Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

It seems serialconnect didn't build on x86_64 due to an ambiguous call to BMenu::RemoveItem().

I'm unsure how to fix the ambiguity (as seen in the following stdio output link from the buildslave), but it seemed like an inefficient way to delete menu items anyway, since we have a RemoveItems() method now.

http://mmadia.dyndns.org:8010/builders/x86_64-any-host/builds/1263/steps/%5Bx86_64%5D/logs/stdio

Attached patch converts repeated RemoveItem() calls to a single RemoveItems() call. Hopefully I got it right :)

Attachments (1)

0001-Remove-all-menu-items-in-unambiguous-way-on-x86_64.patch (876 bytes) - added by umccullough 6 years ago.
Updated patch with proper email

Download all attachments as: .zip

Change History (4)

comment:1 Changed 6 years ago by umccullough

Has a Patch: set

comment:2 Changed 6 years ago by anevilyak

Owner: changed from nobody to anevilyak
Status: newin-progress

Changed 6 years ago by umccullough

Updated patch with proper email

comment:3 Changed 6 years ago by anevilyak

Resolution: fixed
Status: in-progressclosed

Applied in hrev46418, thanks! It should further be noted that it fixes a memory leak, as the previous approach removed all the menu items without also deleting them.

Note: See TracTickets for help on using tickets.