Opened 10 years ago
Closed 10 years ago
#10237 closed bug (fixed)
[PATCH] Fix serialconnect build on x86_64
| Reported by: | umccullough | Owned by: | anevilyak |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Applications | Version: | R1/Development |
| Keywords: | serialconnect x86_64 | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
It seems serialconnect didn't build on x86_64 due to an ambiguous call to BMenu::RemoveItem().
I'm unsure how to fix the ambiguity (as seen in the following stdio output link from the buildslave), but it seemed like an inefficient way to delete menu items anyway, since we have a RemoveItems() method now.
http://mmadia.dyndns.org:8010/builders/x86_64-any-host/builds/1263/steps/%5Bx86_64%5D/logs/stdio
Attached patch converts repeated RemoveItem() calls to a single RemoveItems() call. Hopefully I got it right :)
Attachments (1)
Change History (4)
comment:1 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → in-progress |
by , 10 years ago
| Attachment: | 0001-Remove-all-menu-items-in-unambiguous-way-on-x86_64.patch added |
|---|
comment:3 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | in-progress → closed |
Applied in hrev46418, thanks! It should further be noted that it fixes a memory leak, as the previous approach removed all the menu items without also deleting them.
Note:
See TracTickets
for help on using tickets.
Updated patch with proper email