#10655 closed enhancement (fixed)
Jam help target does not contain info on how to build haiku targets with specific profiles
Reported by: | arvindsraj | Owned by: | bonefish |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Build System | Version: | R1/Development |
Keywords: | jam, help target, build profiles gsoc2014 | Cc: | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
The help target of jam does not provide any information on how to build targets for specific profiles such as nightly, bootstrap and release. Adding this information would help decide which specific target is required.
Attachments (2)
Change History (12)
comment:1 by , 11 years ago
patch: | 0 → 1 |
---|
comment:2 by , 11 years ago
Keywords: | gsoc2014 added |
---|
comment:3 by , 11 years ago
by , 11 years ago
Attachment: | 0001-Jam-help-now-displays-profile-specific-build-informa.patch added |
---|
comment:4 by , 11 years ago
In the new revision of the earlier patch, the lines with length greater than 80 have been split over multiple lines of almost equivalent length.
comment:5 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Applied in hrev47003. There were some indentation problems, and some lines were still too long, but I fixed them myself.
comment:6 by , 11 years ago
Sorry about the indentation problems. I'm surprised the checkstyle script available in the coding guidelines didn't throw up any issues about long lines - I should check it out again sometime. Thanks for the feedback!
comment:7 by , 11 years ago
The python version of the script checks for 80 ascii characters, instead of 80 columns. It doesn't account the fact that a single tab character is 4 columns. The vim version of the script can do this, but it didn't seem easily possible to do it in the Python version. Patches welcome of course ;)
comment:8 by , 11 years ago
There is a typo in the patch which was committed: It's "nightly-raw", not "night-raw" - I am almost sure. :-)
by , 11 years ago
Attachment: | 0001-Fixed-typo-in-help-information-of-a-nightly-build-ta.patch added |
---|
comment:9 by , 11 years ago
Yes indeed - I should have checked more closely. I have fixed the typo and attached the patch in the report again.
This patch breaks the 80-column width limit. You can format things like this:
Coding guidelines: https://www.haiku-os.org/development/coding-guidelines (mostly oriented towards C++, but apply to Jamfiles where it makes sense.