Building Haiku on Haiku fails

[jessicah]

Error I got was error initialising the mime DB. Using the system mimeset worked fine, where the haiku host version of mimeset did not.

[jessicah]

Took quite some time to track down, but found it was an unterminated string in BEntry::set in the libbe_build tree. It now matches the behaviour in libbe's BEntry::_SetTo.

[korli]

This should sync the code with hrev24425. You also need to adjust bufferSize to (B_PATH_NAME_LENGTH - 1).

[tqh]

Looking at _kern_read_link it zero terminates the buffer for all normal cases except when *_bufferSize == 0, shouldn't it always zero-terminate instead?

See ​http://grok.bikemonkey.org/source/xref/haiku/src/build/libroot/fs.cpp#1065

[korli]

Replying to tqh:

Looking at _kern_read_link it zero terminates the buffer for all normal cases except when *_bufferSize == 0, shouldn't it always zero-terminate instead?

You're not allowed to write to a zero-length buffer.

[jessicah]

Changed bufferSize to match the code in src/kits/storage/Entry.cpp

[stippi]

Patch applied, thanks a lot!