package daemon full cpu on new package addition

[kallisti5]

The package_daemon has been having several serious issues in recent builds.

Build a package (any package) via haikuports, and copy it to /boot/system/packages to activate it. After a few packages package_daemon will begin consuming 100% cpu of one core with "job runner" and the new package won't get added.

Screenshot attached. No relevant info or errors in syslog. I've reproduced this on two different systems running gcc4h.

~> uname -a Haiku shredder 1 hrev47213 May 9 2014 01:34:18 BePC x86 Haiku

[anevilyak]

Likely a duplicate of #10817, which was fixed in hrev47215.

[kallisti5]

Ah. Could be. Will test post-hrev47215 and report back.

[kallisti5]

upgraded to hrev47215. package_daemon still doing strange things. see attached crash log.

[anevilyak]

Managed to reproduce it with a debug build of package_daemon + libroot_debug, seems it's trying to remove an entry from a hash table that's already been destroyed. Attached corresponding crash report with full variable dump. Unfortunately don't have more time to dig into it further at the moment, but perhaps it might help shed some light on what's going on.

[anevilyak]

On second thought, might have found it: in Volume's ​destructor, the package file manager is destroyed before calling SetLatestState(). Thus, when SetLatestState() destroys the previous latest state, any packages attached to it get freed, which in turn try to remove themselves from the (already deleted) package file manager. I'd guess that reordering things so that the state setting call happens prior to deleting the file manager should fix this, but that might have other side effects I'm not aware of. Ingo, thoughts?

[bonefish]

Closing as duplicate of #10817. Unless anyone wants to adjust summary and description; then feel free to reopen and close as fixed in hrev47219.