Opened 10 years ago
Closed 8 years ago
#10999 closed bug (fixed)
Tracker copy stalls if it hits a FIFO
Reported by: | Pete | Owned by: | axeld |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Applications/Tracker | Version: | R1/Development |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
I've been using named pipes for a few things, and I typically just leave them sitting around. However, I'll go to copy a directory containing a FIFO, and the copy just stalls when it hits it.
Worse, I can't find any way to cancel the copy, except to reboot.
I think that the copy procedure could just ignore FIFOs, or if not, pop up an alert to either skip or cancel.
Attachments (2)
Change History (9)
follow-up: 2 comment:1 by , 10 years ago
comment:2 by , 10 years ago
Replying to bonefish:
Do you mean you cannot kill Tracker? That would be an (additional) kernel issue.
Oh, sorry -- no. Yes, killing and restarting Tracker would be an alternative, but I guess I think rebooting is just about as quick! (:-/)
And I should make it clear that the Tracker as a whole is not locked. Just the 'Tracker Status' window.
BTW, a related issue that I hadn't picked up on before: FIFOs don't show up as files in a Tracker window, so they can sit there as traps for the careless!
by , 8 years ago
Attachment: | tracker.patch added |
---|
comment:3 by , 8 years ago
patch: | 0 → 1 |
---|
comment:4 by , 8 years ago
Tracker seems to take a similar stance towards special files as does macOS Finder: ignore them (except in the case of directory deletion). This patch applies this stance towards copies.
I played with the alternative approach of warning when tracker encounters a special file while copying, but that seemed unnecessary, and would require string translation.
comment:5 by , 8 years ago
Thanks for the patch, it looks good. Could you please recreate it using git format-patch
? At least I'm unsure how I can apply it (git am --signoff < tracker.patch
doesn't work). How did you produce it? Your patch to #12365 seems to be in the same format.
by , 8 years ago
Attachment: | tracker_v2.patch added |
---|
comment:6 by , 8 years ago
Sorry; I've only previously submitted patches using Github PRs and CVS diffs.
Regenerated with git format-patch
!
comment:7 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
You're welcome! Applied in hrev50879.
Do you mean you cannot kill Tracker? That would be an (additional) kernel issue.