Opened 5 years ago

Closed 5 years ago

#11007 closed bug (fixed)

[LEGAL!] Shortcuts CLV code is actually from Santa's Gift Bag!

Reported by: waddlesplash Owned by: nobody
Priority: high Milestone: R1
Component: Preferences/Shortcuts Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #5420
Has a Patch: yes Platform: All

Description

The code at src/preferences/shortcuts/clv is a 100% match (excluding style, but John changed that in hrev46776) for the Santa's Gift Bag code. May I remind everyone that Santa's Gift Bag is under a really restrictive license which includes the following clause:

Feel free to distribute any components of this archive, but you are required to keep the documentation and license with it. If you wish to distribute modified source, also feel free to do so, but do so in such a manner that it is very clear what was modified, why, how, that it is not an official Santa's Gift Bag release, and you are also required to keep the documentation and license with any modified versions.

  • We have not distributed the license along with the code.
  • We have not distributed the documentation with the code.
  • We did not mark the distribution as "contains modified SBG code"
  • We did not mark what was modified and why.

Obviously going forward we should remove SGB and replace it with Be's ColumnListView that Tracker, Debugger, and HaikuDepot use. What should be done about the existing infringement and why, IANAL so I have no idea.

Attachments (1)

patch-v4.patch (156.6 KB) - added by atalax 5 years ago.
Use ColumnListView instead of Santa's CLV in Shortcuts

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by korli

Related #5420

comment:2 Changed 5 years ago by pulkomandy

Blocking: 5420 added

(In #5420) Closing as #11007 is tracking the CLV issue specifically.

Changed 5 years ago by atalax

Attachment: patch-v4.patch added

Use ColumnListView instead of Santa's CLV in Shortcuts

comment:3 Changed 5 years ago by atalax

Has a Patch: set

comment:4 Changed 5 years ago by atalax

I attached a patch which changes Shortcuts to use ColumnListView

comment:5 Changed 5 years ago by waddlesplash

Which GCI task is this for?

comment:7 Changed 5 years ago by pulkomandy

Resolution: fixed
Status: newclosed

Applied the patch in hrev48638.

Note: See TracTickets for help on using tickets.