Opened 9 years ago

Closed 5 years ago

#5420 closed enhancement (duplicate)

GUI improvement for shortcuts preferences

Reported by: stargater Owned by: leavengood
Priority: normal Milestone: R1
Component: Preferences/Shortcuts Version: R1/Development
Keywords: shortcuts Cc:
Blocked By: #11007 Blocking:
Has a Patch: no Platform: All

Description

Hello, I see in the shortcuts prefernces the non haiku column, i think it is better when we used haiku InterfaceKit, also Haiku columnview. stargater

Attachments (5)

Shortcuts-HIG-Update.patch (30.0 KB) - added by brianluft 8 years ago.
Proposed patch to correct HIG compliance issues
Shortcuts-HIG-Update.png (45.3 KB) - added by brianluft 8 years ago.
Screenshot of proposed fix for HIG compliance issues
Shortcuts-HIG-Update.txt (1.4 KB) - added by brianluft 8 years ago.
Notes for the proposed patch fixing HIG compliance issues
Shortcuts-HIG-Update-Rev2.patch (17.4 KB) - added by brianluft 8 years ago.
Revision 2 of the proposed HIG compliance patch
Shortcuts-HIG-Update-Rev2.png (48.6 KB) - added by brianluft 8 years ago.
Screenshot of the revision 2 changes

Download all attachments as: .zip

Change History (19)

comment:1 Changed 9 years ago by axeld

Yes, the shortcut GUI deserves to be rewritten.

comment:2 Changed 9 years ago by leavengood

Owner: changed from nobody to leavengood
Status: newassigned

Since no one else has been working on Shortcuts and I have had my eye on it for a while, I will take this ticket.

comment:3 Changed 9 years ago by leavengood

Component: PreferencesPreferences/Shortcuts

Changed 8 years ago by brianluft

Attachment: Shortcuts-HIG-Update.patch added

Proposed patch to correct HIG compliance issues

comment:4 Changed 8 years ago by brianluft

Has a Patch: set

Changed 8 years ago by brianluft

Attachment: Shortcuts-HIG-Update.png added

Screenshot of proposed fix for HIG compliance issues

Changed 8 years ago by brianluft

Attachment: Shortcuts-HIG-Update.txt added

Notes for the proposed patch fixing HIG compliance issues

comment:5 Changed 8 years ago by brianluft

I see that no activity has taken place in 10+ months. I have written a patch which fixes the HIG-compliance issues of Shortcuts but does not attempt to replace the ColumnListView with a shared component. Let me know if this is work you have already done, or if this patch is useful despite the continued use of a private ColumnListView control. I am a new contributor without commit access, but I'm an old BeOS programmer having some fun with Haiku.

I've attached the patch, some patch notes, and a screenshot of the changes.

comment:6 Changed 8 years ago by anevilyak

Assuming you're the same Brian Luft I used to know, welcome! In any case, the patch generally looks good, though I'd advise using BControlLook's spacing getters instead of hardcoding it as a #define (c.f. browser:haiku/trunk/headers/os/interface/ControlLook.h#L78)

comment:7 Changed 8 years ago by leavengood

Based on the screenshot this definitely looks better. The reason I haven't done anything yet is I think the Shortcuts GUI needs to be redone completely, but I haven't had the time yet. I started working on a mock-up but got stuck on something which I forget.

But either way this is better than the status quo, so thanks!

If Rene doesn't beat me to it I can try to apply in the next few days.

comment:8 Changed 8 years ago by brianluft

Yeah, it's me! Glad to see some old faces. I'd be happy to revise the patch to use BControlLook; I was unaware of its existence. I should be able to pull that together by tomorrow night. I'll attach the revised patch here when I've got it.

Changed 8 years ago by brianluft

Revision 2 of the proposed HIG compliance patch

Changed 8 years ago by brianluft

Screenshot of the revision 2 changes

comment:9 Changed 8 years ago by brianluft

I have attached revision 2 of the proposed patch. It now uses BControlLook to get the interface spacing. This has "puffed up" the interface a little bit as you can see in the screenshot, but it should be compliant with the rest of the system now. Additionally, I removed Pe's trailing space reformatting in unrelated code from the patch, so that the intention of the patch is more clear just by reading it.

comment:10 Changed 8 years ago by anevilyak

Owner: changed from leavengood to anevilyak
Status: assignedin-progress

comment:11 Changed 8 years ago by anevilyak

Owner: changed from anevilyak to leavengood
Status: in-progressassigned

Applied in hrev42363, thanks! Leaving this ticket open for now since ideally it should also be changed to use BColumnListView rather than the SGB one. On a related note, you may also want to look at Haiku's layout classes and get familiar with them, since they pretty much eliminate the need to do the kind of manual control layouting being done here.

comment:12 Changed 8 years ago by mmu_man

Has a Patch: unset

comment:13 Changed 8 years ago by mmu_man

Marked the v2 files as obsolete so this ticket doesn't appear in the list of pending tickets with a patch attached anymore. Leaving it open as a reminder to switch to our CLV & Layout kit.

comment:14 Changed 5 years ago by pulkomandy

Blocked By: 11007 added
Resolution: duplicate
Status: assignedclosed

Closing as #11007 is tracking the CLV issue specifically.

Note: See TracTickets for help on using tickets.