GUI improvement for shortcuts preferences

[stargater]

Hello, I see in the shortcuts prefernces the non haiku column, i think it is better when we used haiku InterfaceKit, also Haiku columnview. stargater

[axeld]

Yes, the shortcut GUI deserves to be rewritten.

[leavengood]

Since no one else has been working on Shortcuts and I have had my eye on it for a while, I will take this ticket.

[brianluft]

Proposed patch to correct HIG compliance issues

[brianluft]

Screenshot of proposed fix for HIG compliance issues

[brianluft]

Notes for the proposed patch fixing HIG compliance issues

[brianluft]

I see that no activity has taken place in 10+ months. I have written a patch which fixes the HIG-compliance issues of Shortcuts but does not attempt to replace the ColumnListView with a shared component. Let me know if this is work you have already done, or if this patch is useful despite the continued use of a private ColumnListView control. I am a new contributor without commit access, but I'm an old BeOS programmer having some fun with Haiku.

I've attached the patch, some patch notes, and a screenshot of the changes.

[anevilyak]

Assuming you're the same Brian Luft I used to know, welcome! In any case, the patch generally looks good, though I'd advise using BControlLook's spacing getters instead of hardcoding it as a #define (c.f. browser:haiku/trunk/headers/os/interface/ControlLook.h#L78)

[leavengood]

Based on the screenshot this definitely looks better. The reason I haven't done anything yet is I think the Shortcuts GUI needs to be redone completely, but I haven't had the time yet. I started working on a mock-up but got stuck on something which I forget.

But either way this is better than the status quo, so thanks!

If Rene doesn't beat me to it I can try to apply in the next few days.

[brianluft]

Yeah, it's me! Glad to see some old faces. I'd be happy to revise the patch to use BControlLook; I was unaware of its existence. I should be able to pull that together by tomorrow night. I'll attach the revised patch here when I've got it.

[brianluft]

Revision 2 of the proposed HIG compliance patch

[brianluft]

Screenshot of the revision 2 changes

[brianluft]

I have attached revision 2 of the proposed patch. It now uses BControlLook to get the interface spacing. This has "puffed up" the interface a little bit as you can see in the screenshot, but it should be compliant with the rest of the system now. Additionally, I removed Pe's trailing space reformatting in unrelated code from the patch, so that the intention of the patch is more clear just by reading it.

[anevilyak]

Applied in hrev42363, thanks! Leaving this ticket open for now since ideally it should also be changed to use BColumnListView rather than the SGB one. On a related note, you may also want to look at Haiku's layout classes and get familiar with them, since they pretty much eliminate the need to do the kind of manual control layouting being done here.

[mmu_man]

Marked the v2 files as obsolete so this ticket doesn't appear in the list of pending tickets with a patch attached anymore. Leaving it open as a reminder to switch to our CLV & Layout kit.

[pulkomandy]

Closing as #11007 is tracking the CLV issue specifically.