Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11096 closed bug (invalid)

[Blacklisting] targets all packages, not just the one specified

Reported by: ttcoder Owned by: bonefish
Priority: normal Milestone: R1/beta1
Component: File Systems/packagefs Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

This is hrev47610 I tried using the proper way described in #10041, i.e. not using the "touch" hack at all but replacing that hack with blacklisting instead.

It does not work, both the mainline driver and my patched package are blacklisted. It seems there is still a tweak left to do in the blacklisting code: enforce the "package" field: if my blacklisting specifies "add-on/kernel...../hda" in package "haiku" then it should only blacklist the one in package haiku, not in package ttcoder-hda-patch :-)

Things work well if I blacklist and put the "patched" hda driver in the non-packaged hierarchy, or if I forego using blacklisting at all and put the patched hda driver in an .hpkg but with a hacked mod-time of 1st January 2037. But these are less convenient approaches.

Change History (4)

comment:1 by ttcoder, 10 years ago

~/Desktop> ls /dev/audio/hmulti/hda/
ls: cannot access /dev/audio/hmulti/hda/: No such file or directory
~/Desktop> cat /system/settings/packages
Package haiku {
        EntryBlacklist {
                add-ons/kernel/drivers/dev/audio/hmulti/hda
#               add-ons/kernel/file_systems/cdda
                add-ons/kernel/drivers/dev/graphics/radeon_hd
        }
}
~/Desktop> ls -l /system/packages/h*
-rw-r--r-- 1 user root  3144321 2014-08-01 10:59 /system/packages/haiku_devel-r1~alpha4_pm_hrev47610-1-x86_gcc2.hpkg
-rw-r--r-- 1 user root   312340 2014-08-01 10:47 /system/packages/haiku_loader-r1~alpha4_pm_hrev47610-1-x86_gcc2.hpkg
-rw-r--r-- 1 user root   594192 2014-08-01 10:59 /system/packages/haiku_x86_devel-r1~alpha4_pm_hrev47610-1-x86_gcc2.hpkg
-rw-r--r-- 1 user root  6531894 2014-08-01 10:47 /system/packages/haiku_x86-r1~alpha4_pm_hrev47610-1-x86_gcc2.hpkg
-rw-r--r-- 1 user root 53985403 2014-08-01 10:56 /system/packages/haiku-r1~alpha4_pm_hrev47610-1-x86_gcc2.hpkg
-rw-r--r-- 1 user root 16192738 2014-07-25 17:09 /system/packages/haikuwebkit_x86-1.4.1-3-x86_gcc2.hpkg
-rw-r--r-- 1 user root    26418 2014-08-02 11:09 /system/packages/hda3_1.1-1.hpkg
~/Desktop> package list -p /system/packages/hda3_1.1-1.hpkg 
add-ons
add-ons/kernel
add-ons/kernel/drivers
add-ons/kernel/drivers/bin
add-ons/kernel/drivers/bin/hda
.PackageInfo

Hmmm gotta check something..

comment:2 by ttcoder, 10 years ago

Please close as invalid, another user error from me (my blacklisting referred to the hda symlink in dev/audio/ whereas the package overrides the file itself in drivers/bin/ ; I've fixed the blacklist and now it works fine).

Incidentally, I've noticed I have to reboot in order to test each new hda build: doing a "restart media services" always reloads the old copy of the driver.. Not necessarily a packagefs issue though, maybe the media_server keeps a copy of the driver in memory and only lets go of it on reboot..

comment:3 by korli, 10 years ago

Resolution: invalid
Status: newclosed

comment:4 by pulkomandy, 10 years ago

Milestone: R1/alpha5R1/beta1
Note: See TracTickets for help on using tickets.