Opened 5 years ago

Closed 5 years ago

#11115 closed bug (fixed)

Makefile-Engine refuses to use relative RDEFs

Reported by: waddlesplash Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Build System Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

  1. Create a new Makefile-Engine project
  2. Add some resources in a subdirectory (e.g. "resources/file.rdef")
  3. "make"

Fails because "no rule to make target file.rsrc needed by APPNAME". If you move the rdef to the directory the makefile is in and adjust the RDEF= accordingly, it works.

This isn't the behavior advertised in the template Makefile; it claims that relative paths should work just fine.

Attachments (1)

MakefileEngine.patch (2.1 KB ) - added by waddlesplash 5 years ago.
patch

Download all attachments as: .zip

Change History (6)

by waddlesplash, 5 years ago

Attachment: MakefileEngine.patch added

patch

comment:1 by waddlesplash, 5 years ago

Has a Patch: set

comment:2 by waddlesplash, 5 years ago

Attached is a patch file that fixes the problem for me. Sorry it isn't in git-patch format, but here's what I think the commit message should be:

Makefile-Engine: fix issues with paths.

This resolves #11115 (relative RDEFs are not handled properly) as
well as removing most of the remaining hardcoded paths. Should
help with writing HaikuPorter recipes.

comment:3 by bonefish, 5 years ago

Owner: changed from bonefish to nobody
Status: newassigned

comment:4 by waddlesplash, 5 years ago

Owner: changed from nobody to pulkomandy

Oh sorry Ingo, meant to assign this to Adrien. (He even reviewed it over IRC and said it looked good to him; he probably just hasn't pushed it yet.)

comment:5 by pulkomandy, 5 years ago

Resolution: fixed
Status: assignedclosed

Applied an even simpler fix in hrev47672.

Note: See TracTickets for help on using tickets.