Opened 5 years ago

Closed 5 years ago

#11204 closed bug (fixed)

[Debugger] crashes in UiUtils::FunctionNameForFrame ()

Reported by: diver Owned by: anevilyak
Priority: normal Milestone: R1
Component: Applications/Debugger Version: R1/Development
Keywords: Cc: bonefish
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

hrev47783.

I started top in the Terminal and when it crashed I clicked Save debug report which also crashed.

Attachments (1)

Debugger-774-debug-31-08-2014-06-45-19.report (14.6 KB ) - added by diver 5 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 by anevilyak, 5 years ago

Cc: bonefish added

Right now I'm not entirely certain as to what to make of this one. If I'm reading the disassembly correctly, the crash appears to occur around http://cgit.haiku-os.org/haiku/tree/src/apps/debugger/user_interface/util/UiUtils.cpp#n113 . However, I see nothing obviously wrong with how things are being handled there. Looking further up the stack, The only potential problem I see is that http://cgit.haiku-os.org/haiku/tree/src/apps/debugger/controllers/DebugReportGenerator.cpp#n476 can potentially exit the initial loop without reacquiring the team lock if it's interrupted while acquiring the team data semaphore, but then successfully gets the stack trace immediately after said continue.

In that case, it would retrieve the statement corresponding to the IP from the team without having the team locked, which I suppose could possibly lead to one or the other of the pointers being passed into FunctionNameForFrame() being invalid, but I'm uncertain. A second pair of eyes would be helpful.

comment:2 by anevilyak, 5 years ago

Resolution: fixed
Status: newclosed

Hopefully fixed in hrev47824. Please reopen if seen again.

Note: See TracTickets for help on using tickets.