Opened 10 years ago
Closed 7 years ago
#11246 closed bug (fixed)
Assertion failure in new x86_64 user memory functions
| Reported by: | xyzzy | Owned by: | pdziepak |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | System/Kernel | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | #11281 | Blocking: | |
| Platform: | x86-64 |
Description
With the new user memory functions added in hrev47860, I just got an assertion failure when shutting down. Stacktrace attached. Looks to be due to a nested call to user_access (user_strlcpy -> fault -> user_memcpy -> assert).
Attachments (2)
Change History (10)
by , 10 years ago
| Attachment: | stacktrace.txt added |
|---|
comment:1 by , 10 years ago
I don't think that this second user_memcpy() is really needed. I will look into it more closely later today.
comment:2 by , 10 years ago
I didn't have much luck trying to reproduce this bug. Could you try the attached patch and see if it solves the problem?
by , 10 years ago
| Attachment: | 0001-kernel-pagecache-provided-buffers-are-not-always-in-.patch added |
|---|
comment:3 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:4 by , 10 years ago
I only managed to hit the bug once. It happened when I shut down after trying to build Haiku under a VM with too little memory (the build process ran out of memory). I've just tried doing the same thing with the patch applied and it didn't crash this time. The patch looks correct to me at least, so I think it probably fixes this.
comment:5 by , 10 years ago
| Blocked By: | 11281 added |
|---|
follow-up: 8 comment:7 by , 7 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
I get the same assertion failure in hrev51931 x86_64 by running profile -f -i100 Time.
comment:8 by , 7 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Stacktrace