[Pe] : some keybindings are broken

[ttcoder]

After upgrading to hrev47850 from 47700-ish range, Pe lost the ability to recognize Alt-Z for Undo, Shift-Alt-Z for Redo, and a couple others. Most of the keybindings still work. Other apps are not affected, only Pe.

Deletings config/settings/pe/keybindings does not fix the problem.

First thought it was a french keymap specific regression, but it occurs also if I change the keymap to US.

The bug is fairly high-profile as it also causes weirdness in the Preferences > Keybindings pane: hitting Alt-Z, the textfield displays Alt-} (curly brace) (?!), hitting alt-B it displays Alt-U (!) and so on for a few others that are no longer mapped correctly.

The Pe package is still 2.4.5 so the breakage might be caused by changes in Haiku itself; filing here rather than github for now.

Might be caused by the keymap-related changes that occured in the Haiku codebase a few weeks ago ?

[anevilyak]

Is it reproducible if you just boot a nightly off a USB stick?

[ttcoder]

Hmmmm are keybindings still saved in pe/keybindings or somewhere else ? Quitting it and relaunching Pe I see it has memorized my changes, even though the file's not there:

~/config/settings/pe> ls keybindings
ls: cannot access keybindings: No such file or directory

@evilyak: going to try with an external hard-drive; will take a few days turn-around time

[waddlesplash]

Yes, this was due to ​https://github.com/olta/pe/pull/13 -- which was supposed to change Pe's keybindings to match Haiku convention more closely. Assigning to Puck so he can have a look at it.

[ttcoder]

Weirdness... After rebooting and relaunching Pe I now see a "keybindings-v2" file indeed, and the previous settings file which I had renamed (while Pe was running) is now gone. So 1) it seems version 2.4.5 includes the changes you mentionned Augustin and 2) Pe must have had an entry_ref+file-descriptor "lock" on my old settings file, even after quitting Pe, which was only released after rebooting... Either that or I lack sleep more than usual.

Anyhow this new code indeed does not work here, the "out of the box" keybindings-v2 settings insist on assigning Alt-Y for undo, and if I open the prefs to change that I see the alt-curly-brace, alt-Delete oddities ..etc.

I've found one setting where the mapping is correct, and which is also is kinda acceptable for my muscle memory: Ctrl-Z (instead of Alt-Z... close enough) so using that for now :-)

[ttcoder]

Confirming, it seems if I blacklist /system/apps/Pe and use the older Pe binary from an old 2.4.4 package the Alt-Z shortcut can be configured again (going through a few hoops as before, but nothing bad). I'll do that for now. Gotta file a ticket over at github as I now realize it's indeed a regression in 2.4.5, not something that was caused by Haiku. Sorry for the noise.